Don't add empty rects during addFocusRingRects

Don't add empty rects during addFocusRingRects

We don't add empty rects during addFocusRingRects except during
generateLineBoxRects in RenderInline::addFocusRingRects.

Empty rects in focus ring rects causes small circle drawn around
the top-left corner of the empty rects on Mac.

Added AbsoluteRectsIgnoringEmptyRectsGeneratorContext for
addFocusRingRects to ignore empty line box rects.

BUG=405791
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180864

[esprehn, 2014-08-21 17:22:08]

https://codereview.chromium.org/492433006/diff/1/Source/core/rendering/Render...
File Source/core/rendering/RenderInline.cpp (right):

https://codereview.chromium.org/492433006/diff/1/Source/core/rendering/Render...
Source/core/rendering/RenderInline.cpp:1366: namespace {
No need for the anonymous namespace. Also why wouldn't the normal
AbsoluteRectsGeneratorContext want to ignore empty rects?

[Xianzhu, 2014-08-21 17:26:29]

https://codereview.chromium.org/492433006/diff/1/Source/core/rendering/Render...
File Source/core/rendering/RenderInline.cpp (right):

https://codereview.chromium.org/492433006/diff/1/Source/core/rendering/Render...
Source/core/rendering/RenderInline.cpp:1366: namespace {
On 2014/08/21 17:22:08, esprehn wrote:
> No need for the anonymous namespace. Also why wouldn't the normal
> AbsoluteRectsGeneratorContext want to ignore empty rects?

I saw yield(FloatRect()) in the code, so wondering if keeping empty rects is
intentional for other GeneratorContext users. I can investigate on this.

[Xianzhu, 2014-08-22 00:12:15]

Added test. PTAL.

https://codereview.chromium.org/492433006/diff/1/Source/core/rendering/Render...
File Source/core/rendering/RenderInline.cpp (right):

https://codereview.chromium.org/492433006/diff/1/Source/core/rendering/Render...
Source/core/rendering/RenderInline.cpp:1366: namespace {
Tried to ignore empty rects for all GeneratorContext users, ran layout tests and
got several failures. The empty rects seem to be needed by the other
GeneratorContext users to behave correctly. So for focus rings, we do need a
special GeneratorContext to ignore the empty rects.

[Xianzhu, 2014-08-22 18:56:20]

+trchen@ and eseidel@ who wrote and reviewed the GeneratorContext code.

[eseidel, 2014-08-23 21:46:01]

lgtm

OK.  Please update the CL descrption before landing.

[Xianzhu, 2014-08-25 16:31:14]

On 2014/08/23 21:46:01, eseidel wrote:
> lgtm
> 
> OK.  Please update the CL descrption before landing.

Done.

[Xianzhu, 2014-08-25 16:31:17]

The CQ bit was checked by wangxianzhu@chromium.org

[commit-bot: I haz the power, 2014-08-25 16:32:21]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/wangxianzhu@chromium.org/492433006/40001

[commit-bot: I haz the power, 2014-08-25 17:31:27]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  mac_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/21038)

[commit-bot: I haz the power, 2014-08-25 18:13:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-25 18:13:17]

Try jobs failed on following builders:
  mac_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/21045)

[Xianzhu, 2014-08-25 18:36:30]

The CQ bit was checked by wangxianzhu@chromium.org

[commit-bot: I haz the power, 2014-08-25 18:36:50]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/wangxianzhu@chromium.org/492433006/60001

[commit-bot: I haz the power, 2014-08-25 19:39:05]

Committed patchset #3 (60001) as 180864