PDF: Do more robust page number parsing in OOP plugin.

chrome/browser/resources/pdf/pdf.js

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 'use strict';
 
 <include src="../../../../ui/webui/resources/js/util.js">
 <include src="pdf_scripting_api.js">
 <include src="viewport.js">
 
@@ skipping 269 matching lines @@
     for (var i = 0; i < paramTokens.length; ++i) {
       var keyValueSplit = paramTokens[i].split('=');
       if (keyValueSplit.length != 2)
         continue;
       paramsDictionary[keyValueSplit[0]] = keyValueSplit[1];
     }
 
     // Order is important as later actions can override the effects
     // of previous actions.
     if ('page' in paramsDictionary) {
-      // value is 1-based.
-      this.viewport_.goToPage(paramsDictionary['page'] - 1);
+      // |pageNumber| is 1-based, but goToPage() take a zero-based page number.
+      var pageNumber = parseInt(paramsDictionary['page']);
+      if (!isNaN(pageNumber))
+        this.viewport_.goToPage(pageNumber - 1);

[raymes, 2014/08/20 00:53:54]

What happens without this?

[Lei Zhang, 2014/08/20 00:57:19]

Without this CL, in goToPage(), we blow past the page bounds checks and try to
get the dimensions for page NaN.

     }
   },
 
   /**
    * @private
    * Update the loading progress of the document in response to a progress
    * message being received from the plugin.
    * @param {number} progress the progress as a percentage.
    */
   updateProgress_: function(progress) {
@@ skipping 267 matching lines @@
 
   /**
    * @type {Viewport} the viewport of the PDF viewer.
    */
   get viewport() {
     return this.viewport_;
   }
 };
 
 var viewer = new PDFViewer();