Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1880)

Issue 492433003: PDF: Do more robust page number parsing in OOP plugin. (Closed)

Created:
6 years, 4 months ago by Lei Zhang
Modified:
6 years, 4 months ago
Reviewers:
raymes, Nikhil
CC:
chromium-reviews, arv+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

PDF: Do more robust page number parsing in OOP plugin. BUG=64309 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290770

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M chrome/browser/resources/pdf/pdf.js View 1 chunk +4 lines, -2 lines 2 comments Download
M chrome/browser/resources/pdf/viewport.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Lei Zhang
6 years, 4 months ago (2014-08-20 00:29:07 UTC) #1
raymes
https://codereview.chromium.org/492433003/diff/1/chrome/browser/resources/pdf/pdf.js File chrome/browser/resources/pdf/pdf.js (right): https://codereview.chromium.org/492433003/diff/1/chrome/browser/resources/pdf/pdf.js#newcode293 chrome/browser/resources/pdf/pdf.js:293: this.viewport_.goToPage(pageNumber - 1); What happens without this?
6 years, 4 months ago (2014-08-20 00:53:54 UTC) #2
raymes
lgtm btw :)
6 years, 4 months ago (2014-08-20 00:54:08 UTC) #3
Lei Zhang
https://codereview.chromium.org/492433003/diff/1/chrome/browser/resources/pdf/pdf.js File chrome/browser/resources/pdf/pdf.js (right): https://codereview.chromium.org/492433003/diff/1/chrome/browser/resources/pdf/pdf.js#newcode293 chrome/browser/resources/pdf/pdf.js:293: this.viewport_.goToPage(pageNumber - 1); On 2014/08/20 00:53:54, raymes wrote: > ...
6 years, 4 months ago (2014-08-20 00:57:19 UTC) #4
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 4 months ago (2014-08-20 00:57:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/492433003/1
6 years, 4 months ago (2014-08-20 00:58:22 UTC) #6
commit-bot: I haz the power
6 years, 4 months ago (2014-08-20 05:37:41 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (1) as 290770

Powered by Google App Engine
This is Rietveld 408576698