Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 492423002: Pepper Flash permission should be const. (Closed)

Created:
6 years, 4 months ago by Lei Zhang
Modified:
6 years, 3 months ago
Reviewers:
viettrungluu
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Pepper Flash permission should be const. Committed: https://crrev.com/9ecb800c3c129578ce352596250f9ca3ab8ad667 Cr-Commit-Position: refs/heads/master@{#291813}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M chrome/common/pepper_flash.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/pepper_flash.cc View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Lei Zhang
not const enough
6 years, 4 months ago (2014-08-22 01:37:40 UTC) #1
viettrungluu
lgtm
6 years, 4 months ago (2014-08-25 21:57:46 UTC) #2
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 4 months ago (2014-08-25 22:01:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/492423002/1
6 years, 4 months ago (2014-08-25 22:02:26 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (1) as 02787ce53b2c4677724fe0bc4ed47bfd2237700a
6 years, 4 months ago (2014-08-26 00:46:10 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:39:27 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9ecb800c3c129578ce352596250f9ca3ab8ad667
Cr-Commit-Position: refs/heads/master@{#291813}

Powered by Google App Engine
This is Rietveld 408576698