Use ONC for Cellular APN and SimLock in Settings

components/onc/onc_constants.cc

Index: components/onc/onc_constants.cc
diff --git a/components/onc/onc_constants.cc b/components/onc/onc_constants.cc
index 4909aedb2e3b3b0543ab81edc95e126898806d23..43f29bf6c6a3d61d9494f7db7f5cd3b0c030b25c 100644
--- a/components/onc/onc_constants.cc
+++ b/components/onc/onc_constants.cc
@@ -91,6 +91,7 @@ const char kHomeProvider[] = "HomeProvider";
 const char kICCID[] = "ICCID";
 const char kIMEI[] = "IMEI";
 const char kIMSI[] = "IMSI";
+const char kLastGoodAPN[] = "LastGoodAPN";
 const char kManufacturer[] = "Manufacturer";
 const char kMDN[] = "MDN";
 const char kMEID[] = "MEID";
@@ -115,6 +116,7 @@ const char kName[] = "Name";
 }  // namespace cellular_provider
 
 namespace cellular_apn {
+const char kApn[] = "APN";

[pneubeck (no reviews), 2014/08/22 08:55:32]

IMHO, the constant name and the value are very confusing:
 cellular_network = {
    ...
    "APN": {
       "apn": "...." ???
    },
    "APNList": [ {
       "apn": ...
     }, { 
     }
    ]
 };

Looking into Shill's source of this property, unveils:
(mobile_operator_info.h:104-109)
   // Encapsulates information on a mobile access point name. This information
  // is usually necessary for 3GPP networks to be able to connect to a mobile
  // network. So far, CDMA networks don't use this information.
  struct MobileAPN {
    // The access point url, which is fed to the modemmanager while connecting.
    std::string apn;

How about "AccessPointUrl" then?
@Arman, does that sound right to you?

[stevenjb, 2014/08/22 17:08:44]

Happy to change this, Arman let me know what you suggest.

[armansito, 2014/08/25 21:48:50]

It's not really a URL though. The thing is, APN stands for "Access Point Name"
and I think that's why we went with "Name" as the field there. I think that
"AccessPointName" definitely sounds better than just "Name", so let's go with
that for now.

[stevenjb, 2014/08/25 22:32:34]

From shill/doc/device-api.txt:

"apn"        The APN, to be used when making
"name"       Optional description of the APN, not localized.
"localized_name" Optional description of the APN, localized.

Maybe spell out AccessPointName to separate it from the wrapper object, i.e.
APN.AccessPointName?

 const char kName[] = "Name";
 const char kUsername[] = "Username";
 const char kPassword[] = "Password";