Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(930)

Issue 492373004: Fix regression where mouse hover effect is absent on the browser action chevron (Closed)

Created:
6 years, 3 months ago by Devlin
Modified:
6 years, 3 months ago
Reviewers:
Finnur, Peter Kasting
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix regression where mouse hover effect is absent on the browser action chevron It looks like a SetBorder(NULL) crept into https://codereview.chromium.org/324393002, and the result is that the chevron hover effect (i.e., draw a border) is overridden. Remove the call to SetBorder(). BUG=407518 Committed: https://crrev.com/df431f0380f87e053a79f58dc72d0040153076ff Cr-Commit-Position: refs/heads/master@{#292158}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M chrome/browser/ui/views/toolbar/browser_actions_container.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
Devlin
rdevlin.cronin@chromium.org changed reviewers: + finnur@chromium.org, pkasting@chromium.org
6 years, 3 months ago (2014-08-26 18:03:37 UTC) #1
Devlin
Finnur and Peter, please take a look when you can. It doesn't look like we ...
6 years, 3 months ago (2014-08-26 18:03:37 UTC) #2
Peter Kasting
I have no objections, but Finnur is the one who would know better. LGTM if ...
6 years, 3 months ago (2014-08-26 18:06:20 UTC) #3
Finnur
LGTM I totally didn't remember adding this line so I dug up how it could ...
6 years, 3 months ago (2014-08-27 10:46:39 UTC) #4
Devlin
The CQ bit was checked by rdevlin.cronin@chromium.org
6 years, 3 months ago (2014-08-27 13:34:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/492373004/1
6 years, 3 months ago (2014-08-27 13:35:34 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_clang_dbg on tryserver.chromium.linux ...
6 years, 3 months ago (2014-08-27 14:42:40 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as a56fbbaf0fa2be5b500573e0966346a9e0156727
6 years, 3 months ago (2014-08-27 15:37:40 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:51:53 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/df431f0380f87e053a79f58dc72d0040153076ff
Cr-Commit-Position: refs/heads/master@{#292158}

Powered by Google App Engine
This is Rietveld 408576698