Issue 492323003: downloads: Don't navigate to /# when a user clicks various links on

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 492323003: downloads: Don't navigate to /# when a user clicks various links on (Closed)

Created:
6 years, 4 months ago by Dan Beam

Modified:
6 years, 4 months ago

Reviewers:
benjhayden

CC:
chromium-reviews, asanka, benjhayden+dwatch_chromium.org, arv+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

downloads: Don't navigate to /# when a user clicks various links on chrome://downloads. R=benjhayden@chromium.org BUG=none TEST=browser_tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291471

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -1 line)			Patch
	M	chrome/browser/resources/downloads/downloads.js	View		1 chunk	+2 lines, -0 lines	0 comments	Download
	M	chrome/browser/ui/webui/downloads_ui_browsertest.js	View		2 chunks	+9 lines, -1 line	0 comments	Download

Total messages: 6 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dbeam@chromium.org/492323003/20001

6 years, 4 months ago (2014-08-22 18:01:47 UTC) #4

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_chromium_gn_compile_rel on tryserver.chromium.linux ...

6 years, 4 months ago (2014-08-22 18:56:14 UTC) #5

commit-bot: I haz the power

6 years, 4 months ago (2014-08-22 19:21:40 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (20001) as 291471