Issue 492323002: Revert of Only build various flash/pnacl/ppapi code when they are enabled.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 492323002: Revert of Only build various flash/pnacl/ppapi code when they are enabled. (Closed)

Created:
6 years, 4 months ago by rlarocque

Modified:
6 years, 4 months ago

Reviewers:
Lei Zhang, David Yen, viettrungluu

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

Revert of Only build various flash/pnacl/ppapi code when they are enabled. (patchset #7 of https://codereview.chromium.org/471263003/) Reason for revert: Suspected of breaking the disable_nacl build. Original issue's description: > Only build various flash/pnacl/ppapi code when they are enabled. > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291069 TBR=dyen@chromium.org,viettrungluu@chromium.org,thestig@chromium.org NOTREECHECKS=true NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291112

Created: 6 years, 4 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+31 lines, -69 lines)			Patch
M	chrome/browser/BUILD.gn	View	2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/browser/browser_process_impl.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/browser_process_impl.cc	View	3 chunks	+1 line, -8 lines	0 comments	Download
M	chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc	View	5 chunks	+3 lines, -10 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	6 chunks	+9 lines, -9 lines	0 comments	Download
M	chrome/chrome_browser_ui.gypi	View	4 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/chrome_common.gypi	View	4 chunks	+6 lines, -11 lines	0 comments	Download
M	chrome/chrome_tests_unit.gypi	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/common/BUILD.gn	View	2 chunks	+2 lines, -5 lines	0 comments	Download
M	chrome/common/chrome_content_client.cc	View	9 chunks	+6 lines, -17 lines	0 comments	Download

Total messages: 3 (0 generated)

rlarocque

Created Revert of Only build various flash/pnacl/ppapi code when they are enabled.

6 years, 4 months ago (2014-08-21 16:59:38 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rlarocque@chromium.org/492323002/1

6 years, 4 months ago (2014-08-21 17:01:38 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (1) as 291112