Issue 492263002: Start incremental marking in idle time handler only if it is worthwhile.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 492263002: Start incremental marking in idle time handler only if it is worthwhile. (Closed)

Created:
6 years, 4 months ago by ulan

Modified:
6 years, 4 months ago

Reviewers:
Hannes Payer (out of office)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

Start incremental marking in idle time handler only if it is worthwhile. BUG= R=hpayer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23285

Patch Set 4 : #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+38 lines, -16 lines)			Patch
M	src/heap/gc-idle-time-handler.h	View	1	2 chunks	+9 lines, -3 lines	0 comments	Download
M	src/heap/gc-idle-time-handler.cc	View	1 2 3	2 chunks	+10 lines, -8 lines	0 comments	Download
M	src/heap/heap.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/heap/heap.cc	View	1 2	3 chunks	+17 lines, -5 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Hannes Payer (out of office)

https://codereview.chromium.org/492263002/diff/1/src/heap/heap.cc File src/heap/heap.cc (right): https://codereview.chromium.org/492263002/diff/1/src/heap/heap.cc#newcode4307 src/heap/heap.cc:4307: WorthActivatingIncrementalMarking()) { As discussed offline, can we move that ...

6 years, 4 months ago (2014-08-21 15:25:18 UTC) #2

Hannes Payer (out of office)

I like it, one nit. LGTM https://codereview.chromium.org/492263002/diff/20001/src/heap/heap.cc File src/heap/heap.cc (right): https://codereview.chromium.org/492263002/diff/20001/src/heap/heap.cc#newcode4287 src/heap/heap.cc:4287: return incremental_marking()->WorthActivating() && ...

6 years, 4 months ago (2014-08-21 15:46:20 UTC) #3

ulan

6 years, 4 months ago (2014-08-21 16:05:46 UTC) #4

Message was sent while issue was closed.

Committed patchset #4 manually as 23285 (presubmit successful).

Expand Messages | Collapse Messages

Issue 492263002: Start incremental marking in idle time handler only if it is worthwhile. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Address nit #

Patch Set 4 : #

Messages