Revise several already-committed CLs.

Revise several already-committed CLs.

R=rnystrom@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=29707

[Bob Nystrom, 2013-10-29 17:25:29]

A couple of doc suggestions, but LGTM.

https://codereview.chromium.org/49223004/diff/1/pkg/barback/lib/src/pool.dart
File pkg/barback/lib/src/pool.dart (right):

https://codereview.chromium.org/49223004/diff/1/pkg/barback/lib/src/pool.dart...
pkg/barback/lib/src/pool.dart:9: /// When a resource is needed, the user should
call [acquire]. When the returned
I find mixing "acquire" and "allocated" a tad confusing. Maybe instead of
"acquire", do "request"?

That way it's clear that there's a distinction between a resource you've *asked
for* (request) and a resource you've *been granted* (allocated).

https://codereview.chromium.org/49223004/diff/1/pkg/barback/lib/src/pool.dart...
pkg/barback/lib/src/pool.dart:19: final _pendingResources = new
Queue<Completer<PoolResource>>();
Assuming the above comment, you could call this _requestedResources.

https://codereview.chromium.org/49223004/diff/1/pkg/barback/lib/src/pool.dart...
pkg/barback/lib/src/pool.dart:89: /// A resource has been checked out or
released.
"checked out" -> "allocated".

https://codereview.chromium.org/49223004/diff/1/pkg/barback/lib/src/pool.dart...
pkg/barback/lib/src/pool.dart:124: /// no longer allocated, and that a new
[PoolResource] may be acquired.
"acquired" -> "allocated".

https://codereview.chromium.org/49223004/diff/1/pkg/barback/test/package_grap...
File pkg/barback/test/package_graph/repetition_test.dart (right):

https://codereview.chromium.org/49223004/diff/1/pkg/barback/test/package_grap...
pkg/barback/test/package_graph/repetition_test.dart:15: // exist to stress-test
less-common usage patterns in order root out additional
"order root" -> "order to root".

[nweiz, 2013-10-29 19:27:26]

https://codereview.chromium.org/49223004/diff/1/pkg/barback/lib/src/pool.dart
File pkg/barback/lib/src/pool.dart (right):

https://codereview.chromium.org/49223004/diff/1/pkg/barback/lib/src/pool.dart...
pkg/barback/lib/src/pool.dart:9: /// When a resource is needed, the user should
call [acquire]. When the returned
On 2013/10/29 17:25:29, Bob Nystrom wrote:
> I find mixing "acquire" and "allocated" a tad confusing. Maybe instead of
> "acquire", do "request"?
> 
> That way it's clear that there's a distinction between a resource you've
*asked
> for* (request) and a resource you've *been granted* (allocated).

Done.

https://codereview.chromium.org/49223004/diff/1/pkg/barback/lib/src/pool.dart...
pkg/barback/lib/src/pool.dart:19: final _pendingResources = new
Queue<Completer<PoolResource>>();
On 2013/10/29 17:25:29, Bob Nystrom wrote:
> Assuming the above comment, you could call this _requestedResources.

Done.

https://codereview.chromium.org/49223004/diff/1/pkg/barback/lib/src/pool.dart...
pkg/barback/lib/src/pool.dart:89: /// A resource has been checked out or
released.
On 2013/10/29 17:25:29, Bob Nystrom wrote:
> "checked out" -> "allocated".

Done.

https://codereview.chromium.org/49223004/diff/1/pkg/barback/lib/src/pool.dart...
pkg/barback/lib/src/pool.dart:124: /// no longer allocated, and that a new
[PoolResource] may be acquired.
On 2013/10/29 17:25:29, Bob Nystrom wrote:
> "acquired" -> "allocated".

Done.

https://codereview.chromium.org/49223004/diff/1/pkg/barback/test/package_grap...
File pkg/barback/test/package_graph/repetition_test.dart (right):

https://codereview.chromium.org/49223004/diff/1/pkg/barback/test/package_grap...
pkg/barback/test/package_graph/repetition_test.dart:15: // exist to stress-test
less-common usage patterns in order root out additional
On 2013/10/29 17:25:29, Bob Nystrom wrote:
> "order root" -> "order to root".

Done.

[nweiz, 2013-10-31 21:51:00]

Committed patchset #2 manually as r29707 (presubmit successful).