Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issue 492213004: Deprecate XHR progress event properties 'position' and 'totalSize'. (Closed)

Created:
6 years, 4 months ago by sof
Modified:
6 years, 4 months ago
CC:
blink-reviews, arv+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Deprecate XHR progress event properties 'position' and 'totalSize'. Use the properties 'loaded' and 'total' respectively instead. R=tyoshino@chromium.org, haraken@chromium.org BUG=357112 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180775

Patch Set 1 #

Patch Set 2 : Update expected outputs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -2 lines) Patch
M LayoutTests/http/tests/inspector/timeline-xhr-event-expected.txt View 1 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-LSProgressEvent-ProgressEvent-should-match-expected.txt View 1 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-onProgress-open-should-zero-length-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/frame/UseCounter.cpp View 1 chunk +6 lines, -0 lines 0 comments Download
M Source/core/xml/XMLHttpRequestProgressEvent.idl View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
sof
Please take a look.
6 years, 4 months ago (2014-08-22 12:48:58 UTC) #1
tyoshino (SeeGerritForStatus)
lgtm
6 years, 4 months ago (2014-08-22 12:54:22 UTC) #2
sof
haraken@: time for a rubberstamp? :)
6 years, 4 months ago (2014-08-22 12:59:46 UTC) #3
haraken
LGTM. You're a core owner, so I think you can land this CL without my ...
6 years, 4 months ago (2014-08-22 13:00:54 UTC) #4
sof
On 2014/08/22 13:00:54, haraken wrote: > LGTM. You're a core owner, so I think you ...
6 years, 4 months ago (2014-08-22 13:03:59 UTC) #5
sof
The CQ bit was checked by sigbjornf@opera.com
6 years, 4 months ago (2014-08-22 13:04:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/492213004/1
6 years, 4 months ago (2014-08-22 13:04:57 UTC) #7
sof
The CQ bit was unchecked by sigbjornf@opera.com
6 years, 4 months ago (2014-08-22 13:28:20 UTC) #8
sof
The CQ bit was checked by sigbjornf@opera.com
6 years, 4 months ago (2014-08-22 13:28:51 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/492213004/10003
6 years, 4 months ago (2014-08-22 13:29:02 UTC) #10
commit-bot: I haz the power
6 years, 4 months ago (2014-08-22 14:28:23 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (10003) as 180775

Powered by Google App Engine
This is Rietveld 408576698