Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 492183002: Reenable data URL layout tests which were temporarily skipped until Chromium side change gets landed (Closed)

Created:
6 years, 4 months ago by tyoshino (SeeGerritForStatus)
Modified:
6 years, 3 months ago
Reviewers:
eseidel
CC:
blink-reviews
Project:
blink
Visibility:
Public.

Description

Reenable data URL layout tests which were temporarily skipped until Chromium side change gets landed - Enables the temporarily skipped tests - Change the blob test case to expect failure. This is because it turned out that we cannot use the optimization for data URL loading when XHR is set to load data as Blob. - Delete the unnecessary expectation file Depends on - https://codereview.chromium.org/480413007/ - https://codereview.chromium.org/294193002/ BUG=308768 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181707

Patch Set 1 #

Patch Set 2 : Changed blob test case to expect failure #

Patch Set 3 : Postpone enabling network-status-non-http.html #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -22 lines) Patch
M LayoutTests/TestExpectations View 1 2 3 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-data-url.html View 1 1 chunk +3 lines, -11 lines 0 comments Download
D LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-data-url-expected.txt View 1 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 16 (3 generated)
eseidel
The CQ bit was checked by eseidel@chromium.org
6 years, 4 months ago (2014-08-23 19:44:39 UTC) #1
eseidel
lgtm
6 years, 4 months ago (2014-08-23 19:44:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tyoshino@chromium.org/492183002/1
6 years, 4 months ago (2014-08-23 19:45:13 UTC) #3
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 4 months ago (2014-08-23 20:43:17 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-23 21:06:15 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/21984)
6 years, 4 months ago (2014-08-23 21:06:16 UTC) #6
tyoshino (SeeGerritForStatus)
Thanks Eric for review. But it depends on https://codereview.chromium.org/294193002/. These layout test files are already ...
6 years, 4 months ago (2014-08-26 03:48:15 UTC) #7
tyoshino (SeeGerritForStatus)
Updated to expect failure (just check loading as a Blob doesn't crash the renderer) when ...
6 years, 3 months ago (2014-09-04 08:01:22 UTC) #8
tyoshino (SeeGerritForStatus)
Hmm, inspector/network/network-status-non-http.html got outdated while it has been skipped. I need to update its XPath ...
6 years, 3 months ago (2014-09-04 09:02:45 UTC) #9
eseidel
lgtm
6 years, 3 months ago (2014-09-04 16:12:30 UTC) #10
eseidel
lgtm
6 years, 3 months ago (2014-09-04 16:12:30 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tyoshino@chromium.org/492183002/60001
6 years, 3 months ago (2014-09-10 06:00:47 UTC) #15
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 07:01:38 UTC) #16
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as 181707

Powered by Google App Engine
This is Rietveld 408576698