Issue 492163003: File Manager: Rename media_util.js to thumbnail_loader.js

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 492163003: File Manager: Rename media_util.js to thumbnail_loader.js (Closed)

Created:
6 years, 4 months ago by yoshiki

Modified:
6 years, 4 months ago

Reviewers:
hirono

CC:
chromium-reviews, feature-media-reviews_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yoshiki+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

File Manager: Rename media_util.js to thumbnail_loader.js Now, media_util.js has only THumbnailLoader class ans we can rename it to thumbnail_loader.js. BUG=405838 TEST=Files.app and Gallery.app can launch Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291041

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+5 lines, -429 lines)			Patch
M	ui/file_manager/file_manager/foreground/js/main_scripts.js	View	2 chunks	+1 line, -1 line	0 comments	Download
D	ui/file_manager/file_manager/foreground/js/media/media_util.js	View	1 chunk	+0 lines, -424 lines	0 comments	Download
M	ui/file_manager/file_manager/foreground/js/photo/gallery_scripts.js	View	2 chunks	+1 line, -1 line	0 comments	Download
A +	ui/file_manager/file_manager/foreground/js/thumbnail_loader.js	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	ui/file_manager/file_manager/gallery.html	View	2 chunks	+1 line, -1 line	0 comments	Download
M	ui/file_manager/file_manager/main.html	View	2 chunks	+1 line, -1 line	0 comments	Download
M	ui/file_manager/gallery/gallery.html	View	2 chunks	+1 line, -1 line	0 comments	Download
M	ui/file_manager/gallery/js/gallery_scripts.js	View	2 chunks	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoshiki@chromium.org/492163003/1

6 years, 4 months ago (2014-08-21 07:43:52 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (1) as 291041

Expand Messages | Collapse Messages