chrome/browser/ui/app_list/app_list_service_views.h - Issue 492163002: Fix Profile* lifetime issues in Chrome's AppListViewDelegate

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/app_list/app_list_service_views.h

Issue 492163002: Fix Profile* lifetime issues in Chrome's AppListViewDelegate (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Add constructor comment Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « chrome/browser/ui/app_list/app_list_service_unittest.cc ('k') | chrome/browser/ui/app_list/app_list_service_views.cc » ('j') | no next file with comments »

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CHROME_BROWSER_UI_APP_LIST_APP_LIST_SERVICE_VIEWS_H_	5 #ifndef CHROME_BROWSER_UI_APP_LIST_APP_LIST_SERVICE_VIEWS_H_

6 #define CHROME_BROWSER_UI_APP_LIST_APP_LIST_SERVICE_VIEWS_H_	6 #define CHROME_BROWSER_UI_APP_LIST_APP_LIST_SERVICE_VIEWS_H_

7	7

8 #include "base/memory/scoped_ptr.h"	8 #include "base/memory/scoped_ptr.h"

9 #include "chrome/browser/ui/app_list/app_list_service_impl.h"	9 #include "chrome/browser/ui/app_list/app_list_service_impl.h"

10 #include "chrome/browser/ui/app_list/app_list_shower_delegate.h"	10 #include "chrome/browser/ui/app_list/app_list_shower_delegate.h"

(...skipping 22 matching lines...) Expand all Loading...
33 // AppListService overrides:	33 // AppListService overrides:

34 virtual void Init(Profile* initial_profile) OVERRIDE;	34 virtual void Init(Profile* initial_profile) OVERRIDE;

35 virtual void CreateForProfile(Profile* requested_profile) OVERRIDE;	35 virtual void CreateForProfile(Profile* requested_profile) OVERRIDE;

36 virtual void ShowForProfile(Profile* requested_profile) OVERRIDE;	36 virtual void ShowForProfile(Profile* requested_profile) OVERRIDE;

37 virtual void DismissAppList() OVERRIDE;	37 virtual void DismissAppList() OVERRIDE;

38 virtual bool IsAppListVisible() const OVERRIDE;	38 virtual bool IsAppListVisible() const OVERRIDE;

39 virtual gfx::NativeWindow GetAppListWindow() OVERRIDE;	39 virtual gfx::NativeWindow GetAppListWindow() OVERRIDE;

40 virtual Profile* GetCurrentAppListProfile() OVERRIDE;	40 virtual Profile* GetCurrentAppListProfile() OVERRIDE;

41 virtual AppListControllerDelegate* GetControllerDelegate() OVERRIDE;	41 virtual AppListControllerDelegate* GetControllerDelegate() OVERRIDE;

42	42

	43 // AppListServiceImpl overrides:

	44 virtual void DestroyAppList() OVERRIDE;

	45

43 // AppListShowerDelegate overrides:	46 // AppListShowerDelegate overrides:

44 virtual AppListControllerDelegate* GetControllerDelegateForCreate() OVERRIDE;	47 virtual AppListControllerDelegate* GetControllerDelegateForCreate() OVERRIDE;

45	48

46 private:	49 private:

47 // Responsible for creating the app list and responding to profile changes.	50 // Responsible for creating the app list and responding to profile changes.

48 AppListShower shower_;	51 AppListShower shower_;

49	52

50 bool can_dismiss_;	53 bool can_dismiss_;

51 scoped_ptr<AppListControllerDelegate> controller_delegate_;	54 scoped_ptr<AppListControllerDelegate> controller_delegate_;

52	55

53 DISALLOW_COPY_AND_ASSIGN(AppListServiceViews);	56 DISALLOW_COPY_AND_ASSIGN(AppListServiceViews);

54 };	57 };

55	58

56 #endif // CHROME_BROWSER_UI_APP_LIST_APP_LIST_SERVICE_VIEWS_H_	59 #endif // CHROME_BROWSER_UI_APP_LIST_APP_LIST_SERVICE_VIEWS_H_

OLD	NEW