Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1038)

Issue 492153002: Remove TileItemBackground from experimental app list. (Closed)

Created:
6 years, 4 months ago by calamity
Modified:
6 years, 3 months ago
Reviewers:
Matt Giuca
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina
Project:
chromium
Visibility:
Public.

Description

Remove TileItemBackground from experimental app list. This CL removes the white TileItemBackground from the tiles on the experimental app list start page. BUG=349727 Committed: https://crrev.com/3cd167db1ebbbe61fc62405fd70763e35cd9efda Cr-Commit-Position: refs/heads/master@{#291632}

Patch Set 1 : #

Patch Set 2 : remove include #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -55 lines) Patch
M ui/app_list/views/tile_item_view.h View 2 chunks +0 lines, -4 lines 0 comments Download
M ui/app_list/views/tile_item_view.cc View 1 3 chunks +1 line, -51 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
calamity
Pour one out for the tile item background.
6 years, 4 months ago (2014-08-21 03:56:37 UTC) #1
Matt Giuca
Well this is awfully disappointing :((((((((((((((((( lgtm
6 years, 4 months ago (2014-08-21 06:48:05 UTC) #2
calamity
The CQ bit was checked by calamity@chromium.org
6 years, 4 months ago (2014-08-22 02:39:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/calamity@chromium.org/492153002/60001
6 years, 4 months ago (2014-08-22 02:40:54 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_chromium_gn_compile_rel on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-22 05:44:35 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-22 05:47:42 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_rel/builds/8415)
6 years, 4 months ago (2014-08-22 05:47:43 UTC) #7
calamity
The CQ bit was checked by calamity@chromium.org
6 years, 4 months ago (2014-08-25 00:37:45 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/calamity@chromium.org/492153002/60001
6 years, 4 months ago (2014-08-25 00:38:11 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (60001) as 6e96c28a2a59fac44695f03ede293ad3629caa5d
6 years, 4 months ago (2014-08-25 01:33:28 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:32:50 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3cd167db1ebbbe61fc62405fd70763e35cd9efda
Cr-Commit-Position: refs/heads/master@{#291632}

Powered by Google App Engine
This is Rietveld 408576698