extensions/renderer/programmatic_script_injector.h - Issue 492133002: Renderer changes for wiring up shared memory with declarative injection

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/programmatic_script_injector.h

Issue 492133002: Renderer changes for wiring up shared memory with declarative injection (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/declarative_content/content_action.cc ('K') | « extensions/common/extension_messages.h ('k') | extensions/renderer/programmatic_script_injector.cc » ('j') | extensions/renderer/script_injection_manager.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/renderer/programmatic_script_injector.h

diff --git a/extensions/renderer/programmatic_script_injector.h b/extensions/renderer/programmatic_script_injector.h

index 9afb88dee735be192a1822925ba6297f1d8e1a3d..1f896e272b2ef41d6c6fe134087865dac722adfe 100644

--- a/extensions/renderer/programmatic_script_injector.h

+++ b/extensions/renderer/programmatic_script_injector.h

@@ -30,6 +30,9 @@ class ProgrammaticScriptInjector : public ScriptInjector {

blink::WebFrame* web_frame);

virtual ~ProgrammaticScriptInjector();

+ // ScriptInjector implementation.

+ virtual bool is_declarative() const OVERRIDE;

Devlin 2014/08/21 17:06:16 Why?

Mark Dittmer 2014/08/23 12:21:38 Left over from some debugging. I'll get rid of it.

private:

// ScriptInjector implementation.

virtual UserScript::InjectionType script_type() const OVERRIDE;