Fix label for a11y VoiceOver

chrome/browser/resources/history/history.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 <include src="../uber/uber_utils.js">
 <include src="history_focus_manager.js">
 
 ///////////////////////////////////////////////////////////////////////////////
 // Globals:
 /** @const */ var RESULTS_PER_PAGE = 150;
@@ skipping 132 matching lines @@
  *  - useMonthDate: Whether or not the full date should be inserted (used for
  * monthly view).
  * @return {Node} A DOM node to represent the history entry or search result.
  */
 Visit.prototype.getResultDOM = function(propertyBag) {
   var isSearchResult = propertyBag.isSearchResult || false;
   var addTitleFavicon = propertyBag.addTitleFavicon || false;
   var useMonthDate = propertyBag.useMonthDate || false;
   var focusless = propertyBag.focusless || false;
   var node = createElementWithClassName('li', 'entry');
-  var time = createElementWithClassName('div', 'time');
-  var entryBox = createElementWithClassName('label', 'entry-box');
+  var time = createElementWithClassName('label', 'time');
+  var entryBox = createElementWithClassName('div', 'entry-box');
   var domain = createElementWithClassName('div', 'domain');
 
   this.id_ = this.model_.nextVisitId_++;
   var self = this;
 
   // Only create the checkbox if it can be used either to delete an entry or to
   // block/allow it.
   if (this.model_.editingEntriesAllowed) {
     var checkbox = document.createElement('input');
     checkbox.type = 'checkbox';
     checkbox.id = 'checkbox-' + this.id_;
     checkbox.time = this.date.getTime();
     checkbox.addEventListener('click', checkboxClicked);
+    time.setAttribute('for', checkbox.id);
     entryBox.appendChild(checkbox);
 
     if (focusless)
       checkbox.tabIndex = -1;
 
     // Clicking anywhere in the entryBox will check/uncheck the checkbox.
     entryBox.setAttribute('for', checkbox.id);
     entryBox.addEventListener('mousedown', entryBoxMousedown);
     entryBox.addEventListener('click', entryBoxClick);
     entryBox.addEventListener('keydown', this.handleKeydown_.bind(this));
@@ skipping 1927 matching lines @@
   var element = event.target;
   // Do nothing if the event happened in an interactive element.
   for (; element != event.currentTarget; element = element.parentNode) {
     switch (element.tagName) {
       case 'A':
       case 'BUTTON':
       case 'INPUT':
         return;
     }
   }
-  var checkbox = event.currentTarget.control;
+  var checkbox = $(event.currentTarget.getAttribute('for'));
   checkbox.checked = !checkbox.checked;
   handleCheckboxStateChange(checkbox, event.shiftKey);
   // We don't want to focus on the checkbox.
   event.preventDefault();
 }
 
 /**
  * Called when an individual history entry has been removed from the page.
  * This will only be called when all the elements affected by the deletion
  * have been removed from the DOM and the animations have completed.
@@ skipping 79 matching lines @@
     historyView.reload();
 }
 
 // Add handlers to HTML elements.
 document.addEventListener('DOMContentLoaded', load);
 
 // This event lets us enable and disable menu items before the menu is shown.
 document.addEventListener('canExecute', function(e) {
   e.canExecute = true;
 });