Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 492083002: Fix label for a11y VoiceOver (Closed)

Created:
6 years, 4 months ago by hcarmona
Modified:
6 years, 4 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, Patrick Dubroy, pam+watch_chromium.org, arv+watch_chromium.org, dmazzoni
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix label for a11y VoiceOver Made the 'entry-box' label into a div. Made the 'time' div into a label and assigned it for the checkbox. Updated the code that selects the checkbox to prevent introduction of bug where clicking the row would not toggle the checkbox. VoiceOver after change: checkbox: "<history item timestamp> <checked/unchecked> checkbox" url: "visited link <name of link>" drop down: "actions pop up button" The exact words will be different depending on TTS program used, but should be similar for the controls in the list. There are no tests uploaded because these changes rely on VoiceOver to validate. BUG=404870 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291274

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M chrome/browser/resources/history/history.js View 3 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
hcarmona
6 years, 4 months ago (2014-08-21 20:46:24 UTC) #1
Dan Beam
lgtm
6 years, 4 months ago (2014-08-21 21:03:43 UTC) #2
hcarmona
The CQ bit was checked by hcarmona@chromium.org
6 years, 4 months ago (2014-08-21 21:05:25 UTC) #3
Dan Beam
slgtm can you update this comment separately? chrome/browser/resources/history/history.js:2098: * Handle click event for entryBox labels.
6 years, 4 months ago (2014-08-21 21:07:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hcarmona@chromium.org/492083002/1
6 years, 4 months ago (2014-08-21 21:13:07 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-22 00:40:06 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (1) as 291274

Powered by Google App Engine
This is Rietveld 408576698