net/spdy/spdy_http_stream.cc - Issue 492063002: Allow SPDY POSTs to be terminated by an empty FIN data frame.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/spdy/spdy_http_stream.cc

Issue 492063002: Allow SPDY POSTs to be terminated by an empty FIN data frame. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix comment in response to comment Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/spdy/spdy_http_stream.cc

diff --git a/net/spdy/spdy_http_stream.cc b/net/spdy/spdy_http_stream.cc

index 7ae844133890cad55135488700abe4d6ba9e650b..25be33212ec057870d6377fb177d0669dbf2bd3b 100644

--- a/net/spdy/spdy_http_stream.cc

+++ b/net/spdy/spdy_http_stream.cc

@@ -424,6 +424,7 @@ void SpdyHttpStream::OnRequestBodyReadCompleted(int status) {

CHECK_GE(status, 0);

request_body_buf_size_ = status;

const bool eof = request_info_->upload_data_stream->IsEOF();

+ // Only the final fame may have a length of 0.

mef 2014/08/26 12:58:40 nit: fame -> frame. :)

if (eof) {

CHECK_GE(request_body_buf_size_, 0);

} else {

« no previous file with comments | « no previous file | net/spdy/spdy_http_stream_unittest.cc » ('j') | net/spdy/spdy_stream.cc » ('J')