Source/core/rendering/RenderTextControl.cpp - Issue 492053002: Use LayoutRect during addFocusRingRects to avoid loss of precision

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderTextControl.cpp

Issue 492053002: Use LayoutRect during addFocusRingRects to avoid loss of precision (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: NeedsRebaseline (pixel tests about focus rings. 1-pixel width diff at the edge because of different rounding) Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/rendering/RenderTextControl.cpp

diff --git a/Source/core/rendering/RenderTextControl.cpp b/Source/core/rendering/RenderTextControl.cpp

index b1c845b46cd23f8bdd021f6c6cc777e4f22239ff..795c9677ea5b9dc14fc86781f42c214711cab0c8 100644

--- a/Source/core/rendering/RenderTextControl.cpp

+++ b/Source/core/rendering/RenderTextControl.cpp

@@ -283,10 +283,10 @@ void RenderTextControl::computePreferredLogicalWidths()

clearPreferredLogicalWidthsDirty();

}

-void RenderTextControl::addFocusRingRects(Vector<IntRect>& rects, const LayoutPoint& additionalOffset, const RenderLayerModelObject*) const

+void RenderTextControl::addFocusRingRects(Vector<LayoutRect>& rects, const LayoutPoint& additionalOffset, const RenderLayerModelObject*) const

{

if (!size().isEmpty())

- rects.append(pixelSnappedIntRect(additionalOffset, size()));

+ rects.append(LayoutRect(additionalOffset, size()));

}

RenderObject* RenderTextControl::layoutSpecialExcludedChild(bool relayoutChildren, SubtreeLayoutScope& layoutScope)

« no previous file with comments | « Source/core/rendering/RenderTextControl.h ('k') | Source/core/rendering/svg/RenderSVGContainer.h » ('j') | no next file with comments »