Source/core/rendering/svg/RenderSVGImage.cpp - Issue 492053002: Use LayoutRect during addFocusRingRects to avoid loss of precision

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/core/rendering/svg/RenderSVGImage.cpp

Issue 492053002: Use LayoutRect during addFocusRingRects to avoid loss of precision (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: NeedsRebaseline (pixel tests about focus rings. 1-pixel width diff at the edge because of different rounding) Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « Source/core/rendering/svg/RenderSVGImage.h ('k') | Source/core/rendering/svg/RenderSVGShape.h » ('j') | no next file with comments »

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2006 Alexander Kellett <lypanov@kde.org>	2 * Copyright (C) 2006 Alexander Kellett <lypanov@kde.org>

3 * Copyright (C) 2006 Apple Computer, Inc.	3 * Copyright (C) 2006 Apple Computer, Inc.

4 * Copyright (C) 2007 Nikolas Zimmermann <zimmermann@kde.org>	4 * Copyright (C) 2007 Nikolas Zimmermann <zimmermann@kde.org>

5 * Copyright (C) 2007, 2008, 2009 Rob Buis <buis@kde.org>	5 * Copyright (C) 2007, 2008, 2009 Rob Buis <buis@kde.org>

6 * Copyright (C) 2009 Google, Inc.	6 * Copyright (C) 2009 Google, Inc.

7 * Copyright (C) 2009 Dirk Schulze <krit@webkit.org>	7 * Copyright (C) 2009 Dirk Schulze <krit@webkit.org>

8 * Copyright (C) 2010 Patrick Gansterer <paroga@paroga.com>	8 * Copyright (C) 2010 Patrick Gansterer <paroga@paroga.com>

9 *	9 *

10 * This library is free software; you can redistribute it and/or	10 * This library is free software; you can redistribute it and/or

(...skipping 209 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
220 // Update the SVGImageCache sizeAndScales entry in case image loading finish ed after layout.	220 // Update the SVGImageCache sizeAndScales entry in case image loading finish ed after layout.

221 // (https://bugs.webkit.org/show_bug.cgi?id=99489)	221 // (https://bugs.webkit.org/show_bug.cgi?id=99489)

222 m_objectBoundingBox = FloatRect();	222 m_objectBoundingBox = FloatRect();

223 updateImageViewport();	223 updateImageViewport();

224	224

225 invalidateBufferedForeground();	225 invalidateBufferedForeground();

226	226

227 setShouldDoFullPaintInvalidation(true);	227 setShouldDoFullPaintInvalidation(true);

228 }	228 }

229	229

230 void RenderSVGImage::addFocusRingRects(Vector<IntRect>& rects, const LayoutPoint &, const RenderLayerModelObject*) const	230 void RenderSVGImage::addFocusRingRects(Vector<LayoutRect>& rects, const LayoutPo int&, const RenderLayerModelObject*) const

231 {	231 {

232 // this is called from paint() after the localTransform has already been app lied	232 // this is called from paint() after the localTransform has already been app lied

233 IntRect contentRect = enclosingIntRect(paintInvalidationRectInLocalCoordinat es());	233 LayoutRect contentRect = LayoutRect(paintInvalidationRectInLocalCoordinates( ));

234 if (!contentRect.isEmpty())	234 if (!contentRect.isEmpty())

235 rects.append(contentRect);	235 rects.append(contentRect);

236 }	236 }

237	237

238 } // namespace blink	238 } // namespace blink

OLD	NEW