Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Side by Side Diff: Source/core/rendering/RenderBox.h

Issue 492053002: Use LayoutRect during addFocusRingRects to avoid loss of precision (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: NeedsRebaseline (pixel tests about focus rings. 1-pixel width diff at the edge because of different rounding) Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/rendering/RenderBlock.cpp ('k') | Source/core/rendering/RenderBox.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * Copyright (C) 2003, 2006, 2007 Apple Inc. All rights reserved. 4 * Copyright (C) 2003, 2006, 2007 Apple Inc. All rights reserved.
5 * 5 *
6 * This library is free software; you can redistribute it and/or 6 * This library is free software; you can redistribute it and/or
7 * modify it under the terms of the GNU Library General Public 7 * modify it under the terms of the GNU Library General Public
8 * License as published by the Free Software Foundation; either 8 * License as published by the Free Software Foundation; either
9 * version 2 of the License, or (at your option) any later version. 9 * version 2 of the License, or (at your option) any later version.
10 * 10 *
(...skipping 178 matching lines...) Expand 10 before | Expand all | Expand 10 after
189 LayoutRect contentBoxRect() const { return LayoutRect(borderLeft() + padding Left(), borderTop() + paddingTop(), contentWidth(), contentHeight()); } 189 LayoutRect contentBoxRect() const { return LayoutRect(borderLeft() + padding Left(), borderTop() + paddingTop(), contentWidth(), contentHeight()); }
190 // The content box in absolute coords. Ignores transforms. 190 // The content box in absolute coords. Ignores transforms.
191 IntRect absoluteContentBox() const; 191 IntRect absoluteContentBox() const;
192 // The content box converted to absolute coords (taking transforms into acco unt). 192 // The content box converted to absolute coords (taking transforms into acco unt).
193 FloatQuad absoluteContentQuad() const; 193 FloatQuad absoluteContentQuad() const;
194 194
195 // This returns the content area of the box (excluding padding and border). The only difference with contentBoxRect is that computedCSSContentBoxRect 195 // This returns the content area of the box (excluding padding and border). The only difference with contentBoxRect is that computedCSSContentBoxRect
196 // does include the intrinsic padding in the content box as this is what som e callers expect (like getComputedStyle). 196 // does include the intrinsic padding in the content box as this is what som e callers expect (like getComputedStyle).
197 LayoutRect computedCSSContentBoxRect() const { return LayoutRect(borderLeft( ) + computedCSSPaddingLeft(), borderTop() + computedCSSPaddingTop(), clientWidth () - computedCSSPaddingLeft() - computedCSSPaddingRight(), clientHeight() - comp utedCSSPaddingTop() - computedCSSPaddingBottom()); } 197 LayoutRect computedCSSContentBoxRect() const { return LayoutRect(borderLeft( ) + computedCSSPaddingLeft(), borderTop() + computedCSSPaddingTop(), clientWidth () - computedCSSPaddingLeft() - computedCSSPaddingRight(), clientHeight() - comp utedCSSPaddingTop() - computedCSSPaddingBottom()); }
198 198
199 virtual void addFocusRingRects(Vector<IntRect>&, const LayoutPoint& addition alOffset, const RenderLayerModelObject* paintContainer = 0) const OVERRIDE; 199 virtual void addFocusRingRects(Vector<LayoutRect>&, const LayoutPoint& addit ionalOffset, const RenderLayerModelObject* paintContainer) const OVERRIDE;
200 200
201 // Use this with caution! No type checking is done! 201 // Use this with caution! No type checking is done!
202 RenderBox* previousSiblingBox() const; 202 RenderBox* previousSiblingBox() const;
203 RenderBox* nextSiblingBox() const; 203 RenderBox* nextSiblingBox() const;
204 RenderBox* parentBox() const; 204 RenderBox* parentBox() const;
205 205
206 bool canResize() const; 206 bool canResize() const;
207 207
208 // Visual and layout overflow are in the coordinate space of the box. This means that they aren't purely physical directions. 208 // Visual and layout overflow are in the coordinate space of the box. This means that they aren't purely physical directions.
209 // For horizontal-tb and vertical-lr they will match physical directions, bu t for horizontal-bt and vertical-rl, the top/bottom and left/right 209 // For horizontal-tb and vertical-lr they will match physical directions, bu t for horizontal-bt and vertical-rl, the top/bottom and left/right
(...skipping 594 matching lines...) Expand 10 before | Expand all | Expand 10 after
804 if (UNLIKELY(inlineBoxWrapper() != 0)) 804 if (UNLIKELY(inlineBoxWrapper() != 0))
805 deleteLineBoxWrapper(); 805 deleteLineBoxWrapper();
806 } 806 }
807 807
808 ensureRareData().m_inlineBoxWrapper = boxWrapper; 808 ensureRareData().m_inlineBoxWrapper = boxWrapper;
809 } 809 }
810 810
811 } // namespace blink 811 } // namespace blink
812 812
813 #endif // RenderBox_h 813 #endif // RenderBox_h
OLDNEW
« no previous file with comments | « Source/core/rendering/RenderBlock.cpp ('k') | Source/core/rendering/RenderBox.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698