Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Side by Side Diff: Source/core/rendering/RenderBlock.h

Issue 492053002: Use LayoutRect during addFocusRingRects to avoid loss of precision (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: NeedsRebaseline (pixel tests about focus rings. 1-pixel width diff at the edge because of different rounding) Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « LayoutTests/TestExpectations ('k') | Source/core/rendering/RenderBlock.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2007 David Smith (catfish.man@gmail.com) 4 * (C) 2007 David Smith (catfish.man@gmail.com)
5 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All r ights reserved. 5 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All r ights reserved.
6 * 6 *
7 * This library is free software; you can redistribute it and/or 7 * This library is free software; you can redistribute it and/or
8 * modify it under the terms of the GNU Library General Public 8 * modify it under the terms of the GNU Library General Public
9 * License as published by the Free Software Foundation; either 9 * License as published by the Free Software Foundation; either
10 * version 2 of the License, or (at your option) any later version. 10 * version 2 of the License, or (at your option) any later version.
(...skipping 301 matching lines...) Expand 10 before | Expand all | Expand 10 after
312 void setDesiredColumnCountAndWidth(int, LayoutUnit); 312 void setDesiredColumnCountAndWidth(int, LayoutUnit);
313 313
314 public: 314 public:
315 virtual void computeOverflow(LayoutUnit oldClientAfterEdge, bool = false); 315 virtual void computeOverflow(LayoutUnit oldClientAfterEdge, bool = false);
316 protected: 316 protected:
317 virtual void addOverflowFromChildren(); 317 virtual void addOverflowFromChildren();
318 void addOverflowFromPositionedObjects(); 318 void addOverflowFromPositionedObjects();
319 void addOverflowFromBlockChildren(); 319 void addOverflowFromBlockChildren();
320 void addVisualOverflowFromTheme(); 320 void addVisualOverflowFromTheme();
321 321
322 virtual void addFocusRingRects(Vector<IntRect>&, const LayoutPoint& addition alOffset, const RenderLayerModelObject* paintContainer = 0) const OVERRIDE; 322 virtual void addFocusRingRects(Vector<LayoutRect>&, const LayoutPoint& addit ionalOffset, const RenderLayerModelObject* paintContainer) const OVERRIDE;
323 323
324 virtual void computeSelfHitTestRects(Vector<LayoutRect>&, const LayoutPoint& layerOffset) const OVERRIDE; 324 virtual void computeSelfHitTestRects(Vector<LayoutRect>&, const LayoutPoint& layerOffset) const OVERRIDE;
325 325
326 void computeRegionRangeForBlock(RenderFlowThread*); 326 void computeRegionRangeForBlock(RenderFlowThread*);
327 327
328 void updateBlockChildDirtyBitsBeforeLayout(bool relayoutChildren, RenderBox* ); 328 void updateBlockChildDirtyBitsBeforeLayout(bool relayoutChildren, RenderBox* );
329 329
330 virtual bool isInlineBlockOrInlineTable() const OVERRIDE FINAL { return isIn line() && isReplaced(); } 330 virtual bool isInlineBlockOrInlineTable() const OVERRIDE FINAL { return isIn line() && isReplaced(); }
331 331
332 virtual void invalidateTreeIfNeeded(const PaintInvalidationState&) OVERRIDE; 332 virtual void invalidateTreeIfNeeded(const PaintInvalidationState&) OVERRIDE;
(...skipping 171 matching lines...) Expand 10 before | Expand all | Expand 10 after
504 // FIXME: This is temporary as we move code that accesses block flow 504 // FIXME: This is temporary as we move code that accesses block flow
505 // member variables out of RenderBlock and into RenderBlockFlow. 505 // member variables out of RenderBlock and into RenderBlockFlow.
506 friend class RenderBlockFlow; 506 friend class RenderBlockFlow;
507 }; 507 };
508 508
509 DEFINE_RENDER_OBJECT_TYPE_CASTS(RenderBlock, isRenderBlock()); 509 DEFINE_RENDER_OBJECT_TYPE_CASTS(RenderBlock, isRenderBlock());
510 510
511 } // namespace blink 511 } // namespace blink
512 512
513 #endif // RenderBlock_h 513 #endif // RenderBlock_h
OLDNEW
« no previous file with comments | « LayoutTests/TestExpectations ('k') | Source/core/rendering/RenderBlock.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698