Source/core/rendering/svg/RenderSVGContainer.h - Issue 492053002: Use LayoutRect during addFocusRingRects to avoid loss of precision

Side by Side Diff: Source/core/rendering/svg/RenderSVGContainer.h

Issue 492053002: Use LayoutRect during addFocusRingRects to avoid loss of precision (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« Source/core/rendering/RenderObject.cpp ('K') | « Source/core/rendering/RenderTextControl.cpp ('k') | Source/core/rendering/svg/RenderSVGContainer.cpp » ('j') | no next file with comments »

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2004, 2005, 2007 Nikolas Zimmermann <zimmermann@kde.org>	2 * Copyright (C) 2004, 2005, 2007 Nikolas Zimmermann <zimmermann@kde.org>

3 * Copyright (C) 2004, 2005, 2007 Rob Buis <buis@kde.org>	3 * Copyright (C) 2004, 2005, 2007 Rob Buis <buis@kde.org>

4 * Copyright (C) 2009 Google, Inc. All rights reserved.	4 * Copyright (C) 2009 Google, Inc. All rights reserved.

5 * Copyright (C) 2009 Apple Inc. All rights reserved.	5 * Copyright (C) 2009 Apple Inc. All rights reserved.

6 *	6 *

7 * This library is free software; you can redistribute it and/or	7 * This library is free software; you can redistribute it and/or

8 * modify it under the terms of the GNU Library General Public	8 * modify it under the terms of the GNU Library General Public

9 * License as published by the Free Software Foundation; either	9 * License as published by the Free Software Foundation; either

10 * version 2 of the License, or (at your option) any later version.	10 * version 2 of the License, or (at your option) any later version.

(...skipping 43 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
54 virtual RenderObjectChildList* virtualChildren() OVERRIDE FINAL { return chi ldren(); }	54 virtual RenderObjectChildList* virtualChildren() OVERRIDE FINAL { return chi ldren(); }

55 virtual const RenderObjectChildList* virtualChildren() const OVERRIDE FINAL { return children(); }	55 virtual const RenderObjectChildList* virtualChildren() const OVERRIDE FINAL { return children(); }

56	56

57 virtual bool isSVGContainer() const OVERRIDE FINAL { return true; }	57 virtual bool isSVGContainer() const OVERRIDE FINAL { return true; }

58 virtual const char* renderName() const OVERRIDE { return "RenderSVGContainer "; }	58 virtual const char* renderName() const OVERRIDE { return "RenderSVGContainer "; }

59	59

60 virtual void layout() OVERRIDE;	60 virtual void layout() OVERRIDE;

61	61

62 virtual void addChild(RenderObject* child, RenderObject* beforeChild = 0) OV ERRIDE FINAL;	62 virtual void addChild(RenderObject* child, RenderObject* beforeChild = 0) OV ERRIDE FINAL;

63 virtual void removeChild(RenderObject*) OVERRIDE FINAL;	63 virtual void removeChild(RenderObject*) OVERRIDE FINAL;

64 virtual void addFocusRingRects(Vector<IntRect>&, const LayoutPoint& addition alOffset, const RenderLayerModelObject* paintContainer = 0) const OVERRIDE FINAL ;	64 virtual void addFocusRingRects(Vector<LayoutRect>&, const LayoutPoint& addit ionalOffset, const RenderLayerModelObject* paintContainer) const OVERRIDE FINAL;

65	65

66 virtual FloatRect objectBoundingBox() const OVERRIDE FINAL { return m_object BoundingBox; }	66 virtual FloatRect objectBoundingBox() const OVERRIDE FINAL { return m_object BoundingBox; }

67 virtual FloatRect strokeBoundingBox() const OVERRIDE FINAL { return m_stroke BoundingBox; }	67 virtual FloatRect strokeBoundingBox() const OVERRIDE FINAL { return m_stroke BoundingBox; }

68 virtual FloatRect paintInvalidationRectInLocalCoordinates() const OVERRIDE F INAL { return m_paintInvalidationBoundingBox; }	68 virtual FloatRect paintInvalidationRectInLocalCoordinates() const OVERRIDE F INAL { return m_paintInvalidationBoundingBox; }

69	69

70 virtual bool nodeAtFloatPoint(const HitTestRequest&, HitTestResult&, const F loatPoint& pointInParent, HitTestAction) OVERRIDE;	70 virtual bool nodeAtFloatPoint(const HitTestRequest&, HitTestResult&, const F loatPoint& pointInParent, HitTestAction) OVERRIDE;

71	71

72 // Allow RenderSVGTransformableContainer to hook in at the right time in lay out()	72 // Allow RenderSVGTransformableContainer to hook in at the right time in lay out()

73 virtual bool calculateLocalTransform() { return false; }	73 virtual bool calculateLocalTransform() { return false; }

74	74

(...skipping 14 matching lines...) Expand all Loading...
89 FloatRect m_strokeBoundingBox;	89 FloatRect m_strokeBoundingBox;

90 FloatRect m_paintInvalidationBoundingBox;	90 FloatRect m_paintInvalidationBoundingBox;

91 bool m_needsBoundariesUpdate : 1;	91 bool m_needsBoundariesUpdate : 1;

92 };	92 };

93	93

94 DEFINE_RENDER_OBJECT_TYPE_CASTS(RenderSVGContainer, isSVGContainer());	94 DEFINE_RENDER_OBJECT_TYPE_CASTS(RenderSVGContainer, isSVGContainer());

95	95

96 } // namespace blink	96 } // namespace blink

97	97

98 #endif // RenderSVGContainer_h	98 #endif // RenderSVGContainer_h

OLD	NEW