Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Side by Side Diff: Source/core/rendering/RenderObject.h

Issue 492053002: Use LayoutRect during addFocusRingRects to avoid loss of precision (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2000 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 2000 Lars Knoll (knoll@kde.org)
3 * (C) 2000 Antti Koivisto (koivisto@kde.org) 3 * (C) 2000 Antti Koivisto (koivisto@kde.org)
4 * (C) 2000 Dirk Mueller (mueller@kde.org) 4 * (C) 2000 Dirk Mueller (mueller@kde.org)
5 * (C) 2004 Allan Sandfeld Jensen (kde@carewolf.com) 5 * (C) 2004 Allan Sandfeld Jensen (kde@carewolf.com)
6 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2012 Apple Inc. All r ights reserved. 6 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2012 Apple Inc. All r ights reserved.
7 * Copyright (C) 2009 Google Inc. All rights reserved. 7 * Copyright (C) 2009 Google Inc. All rights reserved.
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 997 matching lines...) Expand 10 before | Expand all | Expand 10 after
1008 1008
1009 // Pushes state onto RenderGeometryMap about how to map coordinates from thi s renderer to its container, or ancestorToStopAt (whichever is encountered first ). 1009 // Pushes state onto RenderGeometryMap about how to map coordinates from thi s renderer to its container, or ancestorToStopAt (whichever is encountered first ).
1010 // Returns the renderer which was mapped to (container or ancestorToStopAt). 1010 // Returns the renderer which was mapped to (container or ancestorToStopAt).
1011 virtual const RenderObject* pushMappingToContainer(const RenderLayerModelObj ect* ancestorToStopAt, RenderGeometryMap&) const; 1011 virtual const RenderObject* pushMappingToContainer(const RenderLayerModelObj ect* ancestorToStopAt, RenderGeometryMap&) const;
1012 1012
1013 bool shouldUseTransformFromContainer(const RenderObject* container) const; 1013 bool shouldUseTransformFromContainer(const RenderObject* container) const;
1014 void getTransformFromContainer(const RenderObject* container, const LayoutSi ze& offsetInContainer, TransformationMatrix&) const; 1014 void getTransformFromContainer(const RenderObject* container, const LayoutSi ze& offsetInContainer, TransformationMatrix&) const;
1015 1015
1016 bool createsGroup() const { return isTransparent() || hasMask() || hasFilter () || hasBlendMode(); } 1016 bool createsGroup() const { return isTransparent() || hasMask() || hasFilter () || hasBlendMode(); }
1017 1017
1018 virtual void addFocusRingRects(Vector<IntRect>&, const LayoutPoint& /* addit ionalOffset */, const RenderLayerModelObject* /* paintContainer */ = 0) const { }; 1018 virtual void addFocusRingRects(Vector<LayoutRect>&, const LayoutPoint& addit ionalOffset, const RenderLayerModelObject* paintContainer) const { }
1019 1019
1020 // Compute a list of hit-test rectangles per layer rooted at this renderer. 1020 // Compute a list of hit-test rectangles per layer rooted at this renderer.
1021 virtual void computeLayerHitTestRects(LayerHitTestRects&) const; 1021 virtual void computeLayerHitTestRects(LayerHitTestRects&) const;
1022 1022
1023 // Return the renderer whose background style is used to paint the root back ground. Should only be called on the renderer for which isDocumentElement() is t rue. 1023 // Return the renderer whose background style is used to paint the root back ground. Should only be called on the renderer for which isDocumentElement() is t rue.
1024 RenderObject* rendererForRootBackground(); 1024 RenderObject* rendererForRootBackground();
1025 1025
1026 RespectImageOrientationEnum shouldRespectImageOrientation() const; 1026 RespectImageOrientationEnum shouldRespectImageOrientation() const;
1027 1027
1028 bool isRelayoutBoundaryForInspector() const; 1028 bool isRelayoutBoundaryForInspector() const;
(...skipping 80 matching lines...) Expand 10 before | Expand all | Expand 10 after
1109 void drawDoubleBoxSide(GraphicsContext*, int x1, int y1, int x2, int y2, 1109 void drawDoubleBoxSide(GraphicsContext*, int x1, int y1, int x2, int y2,
1110 int length, BoxSide, Color, int thickness, int adjacentWidth1, int adjac entWidth2, bool antialias); 1110 int length, BoxSide, Color, int thickness, int adjacentWidth1, int adjac entWidth2, bool antialias);
1111 void drawRidgeOrGrooveBoxSide(GraphicsContext*, int x1, int y1, int x2, int y2, 1111 void drawRidgeOrGrooveBoxSide(GraphicsContext*, int x1, int y1, int x2, int y2,
1112 BoxSide, Color, EBorderStyle, int adjacentWidth1, int adjacentWidth2, bo ol antialias); 1112 BoxSide, Color, EBorderStyle, int adjacentWidth1, int adjacentWidth2, bo ol antialias);
1113 void drawSolidBoxSide(GraphicsContext*, int x1, int y1, int x2, int y2, 1113 void drawSolidBoxSide(GraphicsContext*, int x1, int y1, int x2, int y2,
1114 BoxSide, Color, int adjacentWidth1, int adjacentWidth2, bool antialias); 1114 BoxSide, Color, int adjacentWidth1, int adjacentWidth2, bool antialias);
1115 1115
1116 void paintFocusRing(PaintInfo&, const LayoutPoint&, RenderStyle*); 1116 void paintFocusRing(PaintInfo&, const LayoutPoint&, RenderStyle*);
1117 void paintOutline(PaintInfo&, const LayoutRect&); 1117 void paintOutline(PaintInfo&, const LayoutRect&);
1118 void addPDFURLRect(GraphicsContext*, const LayoutRect&); 1118 void addPDFURLRect(GraphicsContext*, const LayoutRect&);
1119 void addChildFocusRingRects(Vector<IntRect>&, const LayoutPoint& additionalO ffset, const RenderLayerModelObject* paintContainer) const; 1119 void addChildFocusRingRects(Vector<LayoutRect>&, const LayoutPoint& addition alOffset, const RenderLayerModelObject* paintContainer) const;
1120 1120
1121 virtual LayoutRect viewRect() const; 1121 virtual LayoutRect viewRect() const;
1122 1122
1123 void clearLayoutRootIfNeeded() const; 1123 void clearLayoutRootIfNeeded() const;
1124 virtual void willBeDestroyed(); 1124 virtual void willBeDestroyed();
1125 void postDestroy(); 1125 void postDestroy();
1126 1126
1127 virtual void insertedIntoTree(); 1127 virtual void insertedIntoTree();
1128 virtual void willBeRemovedFromTree(); 1128 virtual void willBeRemovedFromTree();
1129 1129
(...skipping 441 matching lines...) Expand 10 before | Expand all | Expand 10 after
1571 void showTree(const blink::RenderObject*); 1571 void showTree(const blink::RenderObject*);
1572 void showLineTree(const blink::RenderObject*); 1572 void showLineTree(const blink::RenderObject*);
1573 void showRenderTree(const blink::RenderObject* object1); 1573 void showRenderTree(const blink::RenderObject* object1);
1574 // We don't make object2 an optional parameter so that showRenderTree 1574 // We don't make object2 an optional parameter so that showRenderTree
1575 // can be called from gdb easily. 1575 // can be called from gdb easily.
1576 void showRenderTree(const blink::RenderObject* object1, const blink::RenderObjec t* object2); 1576 void showRenderTree(const blink::RenderObject* object1, const blink::RenderObjec t* object2);
1577 1577
1578 #endif 1578 #endif
1579 1579
1580 #endif // RenderObject_h 1580 #endif // RenderObject_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698