components/autofill/core/browser/autofill_external_delegate.cc - Issue 492043003: Fill on account select in the password manager

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/autofill_external_delegate.cc

Issue 492043003: Fill on account select in the password manager (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Re-added check that form contains a username field. Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/autofill/core/browser/autofill_external_delegate.cc

diff --git a/components/autofill/core/browser/autofill_external_delegate.cc b/components/autofill/core/browser/autofill_external_delegate.cc

index 7cc913947eca844d76d4507eb3686cf4c97ea988..7526af2f5961cd97da4f104f4dbadb459db005e6 100644

--- a/components/autofill/core/browser/autofill_external_delegate.cc

+++ b/components/autofill/core/browser/autofill_external_delegate.cc

@@ -161,12 +161,8 @@ void AutofillExternalDelegate::OnSuggestionsReturned(

// Send to display.

if (query_field_.is_focusable) {

manager_->client()->ShowAutofillPopup(element_bounds_,

- query_field_.text_direction,

- values,

- labels,

- icons,

- ids,

- GetWeakPtr());

+ query_field_.text_direction, values,

+ labels, icons, ids, GetWeakPtr());

Garrett Casto 2014/11/23 07:49:48 I would revert this now just to cut down on the di

jww 2014/11/25 02:46:26 Done.

}