Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Unified Diff: components/autofill/content/renderer/autofill_agent.cc

Issue 492043003: Fill on account select in the password manager (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Re-added check that form contains a username field. Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/content/renderer/autofill_agent.cc
diff --git a/components/autofill/content/renderer/autofill_agent.cc b/components/autofill/content/renderer/autofill_agent.cc
index 2f59e549032081e20bcd5d0471045f284e3f8302..350b7decfc0cd529fec67cb1aade4e4617255062 100644
--- a/components/autofill/content/renderer/autofill_agent.cc
+++ b/components/autofill/content/renderer/autofill_agent.cc
@@ -235,7 +235,7 @@ void AutofillAgent::FocusedNodeChanged(const WebNode& node) {
const WebInputElement* element = toWebInputElement(&web_element);
if (!element || !element->isEnabled() || element->isReadOnly() ||
- !element->isTextField() || element->isPasswordField())
+ !element->isTextField())
return;
element_ = *element;
@@ -575,7 +575,7 @@ void AutofillAgent::ShowSuggestions(const WebFormControlElement& element,
const WebInputElement* input_element = toWebInputElement(&element);
if (input_element) {
- if (!input_element->isTextField() || input_element->isPasswordField())
+ if (!input_element->isTextField())
return;
if (!datalist_only && !input_element->suggestedValue().isEmpty())
return;

Powered by Google App Engine
This is Rietveld 408576698