chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc - Issue 492043003: Fill on account select in the password manager

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc

Issue 492043003: Fill on account select in the password manager (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Re-added check that form contains a username field. Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc

diff --git a/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc b/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc

index 9c7b599705a34098f7c2de881c6eafdc5cfe3350..10c3fe9346903359228fbfbc72b6790d77b931f7 100644

--- a/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc

+++ b/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc

@@ -2177,10 +2177,7 @@ void AutofillDialogControllerImpl::UserEditedOrActivatedInput(

content_bounds,

base::i18n::IsRTL() ?

base::i18n::RIGHT_TO_LEFT : base::i18n::LEFT_TO_RIGHT);

- popup_controller_->Show(popup_values,

- popup_labels,

- popup_icons,

- popup_ids);

+ popup_controller_->Show(popup_values, popup_labels, popup_icons, popup_ids);

Garrett Casto 2014/11/23 07:49:48 Seems like you should just revert this change now.

jww 2014/11/25 02:46:26 Done.

}

void AutofillDialogControllerImpl::FocusMoved() {