Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Unified Diff: components/autofill/content/renderer/password_autofill_agent.h

Issue 492043003: Fill on account select in the password manager (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase on ToT Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/content/renderer/password_autofill_agent.h
diff --git a/components/autofill/content/renderer/password_autofill_agent.h b/components/autofill/content/renderer/password_autofill_agent.h
index df43c3d09476aa35bcd5e9af0eb4b7d8c87a7122..194ffaa9632950db38244081f44ceb312706c356 100644
--- a/components/autofill/content/renderer/password_autofill_agent.h
+++ b/components/autofill/content/renderer/password_autofill_agent.h
@@ -97,8 +97,9 @@ class PasswordAutofillAgent : public content::RenderViewObserver {
bool password_was_edited_last;
PasswordInfo();
};
- typedef std::map<blink::WebElement, PasswordInfo> LoginToPasswordInfoMap;
- typedef std::map<blink::WebElement, blink::WebElement> PasswordToLoginMap;
+ typedef std::map<blink::WebInputElement, PasswordInfo> LoginToPasswordInfoMap;
+ typedef std::map<blink::WebInputElement, blink::WebInputElement>
+ PasswordToLoginMap;
typedef std::map<blink::WebFrame*,
linked_ptr<PasswordForm> > FrameToPasswordFormMap;
@@ -155,7 +156,13 @@ class PasswordAutofillAgent : public content::RenderViewObserver {
bool ShowSuggestionPopup(const PasswordFormFillData& fill_data,
const blink::WebInputElement& user_input,
- bool show_all);
+ bool show_all,
+ bool show_on_password_field = false);
Garrett Casto 2014/11/04 23:35:30 Default arguments are verboten.
jww 2014/11/06 21:28:57 Done.
+
+ // Finds the PasswordInfo that corresponds to the passed in element. The
+ // passed in element can be either a username element or a password element.
+ LoginToPasswordInfoMap::iterator FindPasswordInfoForElement(
+ const blink::WebInputElement& element);
// Fills |login_input| and |password| with the most relevant suggestion from
// |fill_data| and shows a popup with other suggestions.

Powered by Google App Engine
This is Rietveld 408576698