Fill on account select in the password manager

components/autofill/content/common/autofill_messages.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Multiply-included message file, hence no include guard.
 
 #include <string>
 #include <vector>
 
 #include "base/strings/string16.h"
 #include "base/time/time.h"
 #include "components/autofill/content/common/autofill_param_traits_macros.h"
+#include "components/autofill/core/common/autofill_constants.h"
 #include "components/autofill/core/common/form_data.h"
 #include "components/autofill/core/common/form_data_predictions.h"
 #include "components/autofill/core/common/form_field_data.h"
 #include "components/autofill/core/common/form_field_data_predictions.h"
 #include "components/autofill/core/common/password_form.h"
 #include "components/autofill/core/common/password_form_fill_data.h"
 #include "components/autofill/core/common/web_element_descriptor.h"
 #include "content/public/common/common_param_traits.h"
 #include "content/public/common/common_param_traits_macros.h"
 #include "ipc/ipc_message_macros.h"
@@ skipping 256 matching lines @@
 IPC_MESSAGE_ROUTED2(AutofillHostMsg_ShowPasswordEditingPopup,
                     gfx::RectF /* source location */,
                     autofill::PasswordForm)
 
 // Instructs the browser to hide any password generation popups.
 IPC_MESSAGE_ROUTED0(AutofillHostMsg_HidePasswordGenerationPopup)
 
 // Instruct the browser to show a popup with suggestions filled from data
 // associated with |key|. The popup will use |text_direction| for displaying
 // text.
-IPC_MESSAGE_ROUTED5(AutofillHostMsg_ShowPasswordSuggestions,
-                    int /* key */,
-                    base::i18n::TextDirection /*text_direction */,
-                    base::string16 /* username typed by user */,
-                    bool /* show all suggestions */,
-                    gfx::RectF /* input field bounds, window-relative */)
+IPC_MESSAGE_ROUTED5(
+    AutofillHostMsg_ShowPasswordSuggestions,
+    int /* key */,
+    base::i18n::TextDirection /*text_direction */,
+    base::string16 /* username typed by user */,
+    int /* show all suggestions and the field is a password field options */,

[Garrett Casto, 2014/11/23 07:49:48]

I think that keeping the two boolean arguments here is clearer. There are times
when bitmasks are better, but I think that you need more arguments than this.

[jww, 2014/11/25 02:46:26]

If you feel strongly about it, I can make the change but I prefer this for two
reasons:
  (a) At the call sites, it seems much clearer to me what is being selected, and
  (b) Since there's no IPC_MESSAGE_ROUTED6, this prevents us from having to
create a much more complicated arguments structure to pass over the IPC.

Let me know what you think.

+    gfx::RectF /* input field bounds, window-relative */)
 
 // Inform browser of data list values for the curent field.
 IPC_MESSAGE_ROUTED2(AutofillHostMsg_SetDataList,
                     std::vector<base::string16> /* values */,
                     std::vector<base::string16> /* labels */)