Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 49203002: Improvements in positions handling in optimizing compiler. (Closed)

Created:
7 years, 1 month ago by Vyacheslav Egorov (Chromium)
Modified:
7 years, 1 month ago
CC:
v8-dev
Visibility:
Public.

Description

Improvements in positions handling in optimizing compiler. - When building binary arithmetic op and comparison restore source position of the operation itself before building operation itself after it was changed by building operands. This ensures that position recorded for operation points to the operation token instead of pointing to the rightmost operand; - Add support for recording operands' positions and use these positions when inserting HChange instructions; - When generating hydrogen.cfg emit H-instruction position as BCI (previously 0 was emitted), additionally on every lithium instruction emit annotation pointing to corresponding hydrogen-instruction. This allows to easily reach from deopt_id to lithium instruction and from it to hydrogen instruction and source position. BUG= R=danno@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=17765

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+149 lines, -9 lines) Patch
M src/hydrogen.cc View 7 chunks +22 lines, -3 lines 0 comments Download
M src/hydrogen-instructions.h View 6 chunks +125 lines, -4 lines 0 comments Download
M src/hydrogen-representation-changes.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Vyacheslav Egorov (Chromium)
Hello! Please take a look. Combination of this changes make it easier to build tools ...
7 years, 1 month ago (2013-10-28 17:22:23 UTC) #1
Vyacheslav Egorov (Chromium)
friendly ping.
7 years, 1 month ago (2013-11-08 13:22:01 UTC) #2
danno
lgtm
7 years, 1 month ago (2013-11-14 13:22:50 UTC) #3
Vyacheslav Egorov (Google)
Committed patchset #1 manually as r17765 (presubmit successful).
7 years, 1 month ago (2013-11-14 21:00:35 UTC) #4
Vyacheslav Egorov (Google)
7 years, 1 month ago (2013-11-14 21:00:54 UTC) #5
Message was sent while issue was closed.
Thank you for the code review.

Powered by Google App Engine
This is Rietveld 408576698