Install a hook to swap between SkPicture backends with a single define.

Install a hook to swap between SkPicture backends with a single define.

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/c92e550d3656abaf83b134b158756b940d58a907

[reed1, 2014-08-20 21:30:10]

I love the two explicit versions and then the generic one.

nit: I would organize the #ifdef differently.

#ifdef SK_SUPPORT_LEGACY_PICTURE_BACKEND
    return DEPRECATED_beginRecording
#else
    return EXPERIMENTAL_beginRecording
#endif

And then in skia_for_chromium.gypi
    define SK_SUPPORT_LEGACY_PICTURE_BACKEND



This has the subtle difference of defaulting Skia to testing the new backend,
while keeping Chrome on the old backend. This is my std pattern for deprecating
stuff. That said, I'm fine also with your pattern.

lgtm

[mtklein, 2014-08-20 22:36:42]

This is going to need another look, particularly from Robert.  I've done what
Mike suggested and opted Skia in in this CL, converting all the code I know
that's explicitly depending on the old backend.

This won't test cleanly until I fix the recursion in our analysis:
https://codereview.chromium.org/495793002/

[mtklein, 2014-08-21 16:48:08]

On 2014/08/20 22:36:42, mtklein wrote:
> This is going to need another look, particularly from Robert.  I've done what
> Mike suggested and opted Skia in in this CL, converting all the code I know
> that's explicitly depending on the old backend.
> 
> This won't test cleanly until I fix the recursion in our analysis:
> https://codereview.chromium.org/495793002/

Should be okay to land now.  PTAL?

[robertphillips, 2014-08-21 17:31:00]

lgtm + 1 comment change request/suggestion

https://codereview.chromium.org/492023002/diff/60001/include/core/SkPictureRe...
File include/core/SkPictureRecorder.h (right):

https://codereview.chromium.org/492023002/diff/60001/include/core/SkPictureRe...
include/core/SkPictureRecorder.h:43: 
rm "As is the Google way," to keep things open sourcy?

[mtklein, 2014-08-21 17:36:52]

https://codereview.chromium.org/492023002/diff/60001/include/core/SkPictureRe...
File include/core/SkPictureRecorder.h (right):

https://codereview.chromium.org/492023002/diff/60001/include/core/SkPictureRe...
include/core/SkPictureRecorder.h:43: 
On 2014/08/21 17:31:00, robertphillips wrote:
> rm "As is the Google way," to keep things open sourcy?

Done.

[mtklein, 2014-08-21 17:36:56]

The CQ bit was checked by mtklein@google.com

[commit-bot: I haz the power, 2014-08-21 17:37:03]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/492023002/80001

[commit-bot: I haz the power, 2014-08-21 20:07:33]

Committed patchset #5 (80001) as c92e550d3656abaf83b134b158756b940d58a907