Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 491973002: Turn off NEON SkBoxBlurGetPlatformProcs for ARM64 (for now) (Closed)

Created:
6 years, 4 months ago by hal.canary
Modified:
6 years, 4 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Turn off NEON SkBoxBlurGetPlatformProcs for ARM64 (for now) BUG=skia:2845 Committed: https://skia.googlesource.com/skia/+/39cd5b9041cb91a91b753765a13608fa7156d00f

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M src/opts/SkBlurImage_opts_arm.cpp View 1 chunk +2 lines, -0 lines 2 comments Download

Messages

Total messages: 8 (0 generated)
hal.canary
turn the bot green
6 years, 4 months ago (2014-08-20 19:25:32 UTC) #1
djsollen
6 years, 4 months ago (2014-08-20 19:36:55 UTC) #2
Stephen White
LGTM as a stopgap. We should figure this out, though. https://codereview.chromium.org/491973002/diff/1/src/opts/SkBlurImage_opts_arm.cpp File src/opts/SkBlurImage_opts_arm.cpp (right): https://codereview.chromium.org/491973002/diff/1/src/opts/SkBlurImage_opts_arm.cpp#newcode17 ...
6 years, 4 months ago (2014-08-20 19:43:34 UTC) #3
hal.canary
https://codereview.chromium.org/491973002/diff/1/src/opts/SkBlurImage_opts_arm.cpp File src/opts/SkBlurImage_opts_arm.cpp (right): https://codereview.chromium.org/491973002/diff/1/src/opts/SkBlurImage_opts_arm.cpp#newcode17 src/opts/SkBlurImage_opts_arm.cpp:17: #elif defined(SK_CPU_ARM64) // Temporary fix for On 2014/08/20 19:43:33, ...
6 years, 4 months ago (2014-08-20 20:01:49 UTC) #4
Stephen White
On 2014/08/20 20:01:49, Hal Canary wrote: > https://codereview.chromium.org/491973002/diff/1/src/opts/SkBlurImage_opts_arm.cpp > File src/opts/SkBlurImage_opts_arm.cpp (right): > > https://codereview.chromium.org/491973002/diff/1/src/opts/SkBlurImage_opts_arm.cpp#newcode17 ...
6 years, 4 months ago (2014-08-20 20:12:53 UTC) #5
hal.canary
The CQ bit was checked by halcanary@google.com
6 years, 4 months ago (2014-08-20 21:32:36 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/halcanary@google.com/491973002/1
6 years, 4 months ago (2014-08-20 21:33:27 UTC) #7
commit-bot: I haz the power
6 years, 4 months ago (2014-08-20 21:40:15 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (1) as 39cd5b9041cb91a91b753765a13608fa7156d00f

Powered by Google App Engine
This is Rietveld 408576698