Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 491953003: [Cast] Fix shutdown race between CastReceiverImpl/FrameReceiver and frame emit callback run. (Closed)

Created:
6 years, 3 months ago by miu
Modified:
6 years, 3 months ago
Reviewers:
hubbe
CC:
chromium-reviews, hclam+watch_chromium.org, imcheng+watch_chromium.org, hguihot+watch_chromium.org, jasonroberts+watch_google.com, avayvod+watch_chromium.org, pwestin+watch_google.com, feature-media-reviews_chromium.org, miu+watch_chromium.org, hubbe+watch_chromium.org, mikhal+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Cast] Fix shutdown race between CastReceiverImpl/FrameReceiver and frame emit callback run. As described in bug 396413, it was possible for a posted task to be run after CastReceiverImpl/FrameReceiver were destroyed. This change fixes the bug by having FrameReceiver post a cancelable task (i.e., using its WeakPtr) instead. BUG=396413 Committed: https://crrev.com/13d9b1252f8a0d8f0446325f458d23ace590345f Cr-Commit-Position: refs/heads/master@{#292244}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -1 line) Patch
M media/cast/receiver/frame_receiver.h View 1 chunk +7 lines, -0 lines 0 comments Download
M media/cast/receiver/frame_receiver.cc View 2 chunks +10 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
miu
miu@chromium.org changed reviewers: + hubbe@chromium.org
6 years, 3 months ago (2014-08-27 19:30:27 UTC) #1
miu
hubbe: PTAL. A simple fix (one of a few) to help resolve the flaky CastStreamingApiPixelTest.EndToEnd ...
6 years, 3 months ago (2014-08-27 19:30:27 UTC) #2
hubbe
lgtm
6 years, 3 months ago (2014-08-27 20:05:51 UTC) #3
miu
The CQ bit was checked by miu@chromium.org
6 years, 3 months ago (2014-08-27 21:12:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/miu@chromium.org/491953003/1
6 years, 3 months ago (2014-08-27 21:14:04 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as b79c73f894042b551e5c56197e7d34223bcf4f93
6 years, 3 months ago (2014-08-27 22:15:47 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:54:47 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/13d9b1252f8a0d8f0446325f458d23ace590345f
Cr-Commit-Position: refs/heads/master@{#292244}

Powered by Google App Engine
This is Rietveld 408576698