Update the pairing API to include configuration and enrollment.

Update the pairing API to include configuration and enrollment.

BUG=405744
Committed: https://crrev.com/5e61edc42e69df36b816687ece1c831dfdf427dc
Cr-Commit-Position: refs/heads/master@{#292309}

[Zachary Kuznia, 2014-08-20 23:20:44]

Please take a look.

I'll update the Fake implementation to stub out these methods before committing.

[achuithb, 2014-08-20 23:28:13]

https://codereview.chromium.org/491943004/diff/1/components/pairing/controlle...
File components/pairing/controller_pairing_controller.h (right):

https://codereview.chromium.org/491943004/diff/1/components/pairing/controlle...
components/pairing/controller_pairing_controller.h:63: virtual void
AddObserver(Observer* observer) = 0;
Same comment about AddObserver/RemoveObserver as the other file.

https://codereview.chromium.org/491943004/diff/1/components/pairing/host_pair...
File components/pairing/host_pairing_controller.h (right):

https://codereview.chromium.org/491943004/diff/1/components/pairing/host_pair...
components/pairing/host_pairing_controller.h:62: virtual void
AddObserver(Observer* observer) = 0;
Since you're updating this file, can we move these two calls
(AddObserver/RemoveObserver) to the bottom of this file? I feel like they are
generic boilerplate that shouldn't be the first thing you see in the interface.

[Zachary Kuznia, 2014-08-20 23:34:23]

https://codereview.chromium.org/491943004/diff/1/components/pairing/controlle...
File components/pairing/controller_pairing_controller.h (right):

https://codereview.chromium.org/491943004/diff/1/components/pairing/controlle...
components/pairing/controller_pairing_controller.h:63: virtual void
AddObserver(Observer* observer) = 0;
On 2014/08/20 23:28:13, achuithb wrote:
> Same comment about AddObserver/RemoveObserver as the other file.

Done.

https://codereview.chromium.org/491943004/diff/1/components/pairing/host_pair...
File components/pairing/host_pairing_controller.h (right):

https://codereview.chromium.org/491943004/diff/1/components/pairing/host_pair...
components/pairing/host_pairing_controller.h:62: virtual void
AddObserver(Observer* observer) = 0;
On 2014/08/20 23:28:13, achuithb wrote:
> Since you're updating this file, can we move these two calls
> (AddObserver/RemoveObserver) to the bottom of this file? I feel like they are
> generic boilerplate that shouldn't be the first thing you see in the
interface.

Done.

[dzhioev (left Google), 2014-08-25 17:50:56]

On 2014/08/20 23:20:44, Zachary Kuznia wrote:
> Please take a look.
> 
> I'll update the Fake implementation to stub out these methods before
committing.

Interfaces LGTM.

[Zachary Kuznia, 2014-08-27 20:19:46]

achuith:
Please take a look at the stub implementations.

Thanks,
-Zach

[achuithb, 2014-08-27 21:41:36]

Should we add some browser tests for this stuff?

https://codereview.chromium.org/491943004/diff/60001/chrome/browser/chromeos/...
File chrome/browser/chromeos/login/screens/controller_pairing_screen.cc (right):

https://codereview.chromium.org/491943004/diff/60001/chrome/browser/chromeos/...
chrome/browser/chromeos/login/screens/controller_pairing_screen.cc:203:
std::string account_id =
make this const

https://codereview.chromium.org/491943004/diff/60001/chrome/browser/chromeos/...
chrome/browser/chromeos/login/screens/controller_pairing_screen.cc:205:
std::string domain(gaia::ExtractDomainName(account_id));
make this const

https://codereview.chromium.org/491943004/diff/60001/components/pairing/bluet...
File components/pairing/bluetooth_controller_pairing_controller.cc (right):

https://codereview.chromium.org/491943004/diff/60001/components/pairing/bluet...
components/pairing/bluetooth_controller_pairing_controller.cc:19: const char*
kFakeEnrollmentDomain = "http://fake.com";
Is this used any more?

https://codereview.chromium.org/491943004/diff/60001/components/pairing/bluet...
components/pairing/bluetooth_controller_pairing_controller.cc:318: const
std::string& domain,
Is domain used?

https://codereview.chromium.org/491943004/diff/60001/components/pairing/contr...
File components/pairing/controller_pairing_controller.h (right):

https://codereview.chromium.org/491943004/diff/60001/components/pairing/contr...
components/pairing/controller_pairing_controller.h:90: // Set the values that
will be sent to the Host if it needs to be configured.
s/Host/host

[Zachary Kuznia, 2014-08-27 22:01:49]

Filed a bug for tests:
crbug.com/408321

https://codereview.chromium.org/491943004/diff/60001/chrome/browser/chromeos/...
File chrome/browser/chromeos/login/screens/controller_pairing_screen.cc (right):

https://codereview.chromium.org/491943004/diff/60001/chrome/browser/chromeos/...
chrome/browser/chromeos/login/screens/controller_pairing_screen.cc:203:
std::string account_id =
On 2014/08/27 21:41:36, achuithb wrote:
> make this const

Done.

https://codereview.chromium.org/491943004/diff/60001/chrome/browser/chromeos/...
chrome/browser/chromeos/login/screens/controller_pairing_screen.cc:205:
std::string domain(gaia::ExtractDomainName(account_id));
On 2014/08/27 21:41:36, achuithb wrote:
> make this const

Done.

https://codereview.chromium.org/491943004/diff/60001/components/pairing/bluet...
File components/pairing/bluetooth_controller_pairing_controller.cc (right):

https://codereview.chromium.org/491943004/diff/60001/components/pairing/bluet...
components/pairing/bluetooth_controller_pairing_controller.cc:19: const char*
kFakeEnrollmentDomain = "http://fake.com";
On 2014/08/27 21:41:36, achuithb wrote:
> Is this used any more?

Removed.

https://codereview.chromium.org/491943004/diff/60001/components/pairing/bluet...
components/pairing/bluetooth_controller_pairing_controller.cc:318: const
std::string& domain,
On 2014/08/27 21:41:36, achuithb wrote:
> Is domain used?

Leaving it per the design, as discussed.

https://codereview.chromium.org/491943004/diff/60001/components/pairing/contr...
File components/pairing/controller_pairing_controller.h (right):

https://codereview.chromium.org/491943004/diff/60001/components/pairing/contr...
components/pairing/controller_pairing_controller.h:90: // Set the values that
will be sent to the Host if it needs to be configured.
On 2014/08/27 21:41:36, achuithb wrote:
> s/Host/host

Done.

[achuithb, 2014-08-27 22:04:06]

https://codereview.chromium.org/491943004/diff/80001/components/pairing/bluet...
File components/pairing/bluetooth_controller_pairing_controller.cc (right):

https://codereview.chromium.org/491943004/diff/80001/components/pairing/bluet...
components/pairing/bluetooth_controller_pairing_controller.cc:347: //
TODO(zork): Check that the domain matches. (http://crbug.com/405761)
What are these changes? From a rebase?

[achuithb, 2014-08-27 22:06:07]

lgtm

[Zachary Kuznia, 2014-08-27 22:13:37]

The CQ bit was checked by zork@chromium.org

[commit-bot: I haz the power, 2014-08-27 22:14:38]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/zork@chromium.org/491943004/80001

[commit-bot: I haz the power, 2014-08-27 23:10:16]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[commit-bot: I haz the power, 2014-08-27 23:24:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-27 23:24:34]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Zachary Kuznia, 2014-08-28 02:23:36]

The CQ bit was checked by zork@chromium.org

[commit-bot: I haz the power, 2014-08-28 02:24:22]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/zork@chromium.org/491943004/90001

[commit-bot: I haz the power, 2014-08-28 03:41:21]

Committed patchset #6 (id:90001) as ad6cb5302c094ee4be998f2814b26c9c026b243a

[commit-bot: I haz the power, 2014-09-10 02:57:05]

Patchset 6 (id:??) landed as
https://crrev.com/5e61edc42e69df36b816687ece1c831dfdf427dc
Cr-Commit-Position: refs/heads/master@{#292309}