Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1894)

Unified Diff: slave/skia_slave_scripts/run_nanobench.py

Issue 491943002: pass --properties (Closed) Base URL: https://skia.googlesource.com/buildbot@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: slave/skia_slave_scripts/run_nanobench.py
diff --git a/slave/skia_slave_scripts/run_nanobench.py b/slave/skia_slave_scripts/run_nanobench.py
index 4f2f4f2d5a623392cabe59a7e2b96f986ab5d139..a4cac505c9c07d7cdde711aa2eb9f639101e322e 100644
--- a/slave/skia_slave_scripts/run_nanobench.py
+++ b/slave/skia_slave_scripts/run_nanobench.py
@@ -62,14 +62,12 @@ class RunNanobench(BuildStep):
if self._AnyMatch('Valgrind'):
args.extend(['--loops', '1']) # Don't care about performance on Valgrind.
elif self._perf_data_dir:
- args.extend([
- '--outResultsFile', self._JSONPath(),
- '--gitHash', self._got_revision,
- ])
+ args.extend(['--outResultsFile', self._JSONPath()])
args.append('--key')
args.extend(self._KeyParams())
- args.append('--options')
- args.extend(['build_number', str(self._build_number)])
+ args.append('--properties')
+ args.extend(['gitHash', self._got_revision,
+ 'build_number', str(self._build_number)])
match = []
# Disable known problems.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698