Increase DBus timeout in cryptohome calls to 2 minutes.

Increase DBus timeout in cryptohome calls to 2 minutes.

BUG=378338
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291080

[Denis Kuznetsov (DE-MUC), 2014-08-20 17:31:00]

On 2014/08/20 16:28:33, Denis Kuznetsov wrote:

Feel free to lgtm&cq if you have no comments.

[Darren Krahn, 2014-08-20 17:32:05]

https://chromiumcodereview.appspot.com/491913002/diff/1/chromeos/dbus/cryptoh...
File chromeos/dbus/cryptohome_client.cc (right):

https://chromiumcodereview.appspot.com/491913002/diff/1/chromeos/dbus/cryptoh...
chromeos/dbus/cryptohome_client.cc:31: static const int kTpmDBusTimeoutMs = 60 *
1000;
Where does 1 minute come from, is there data to support it?

We've seen some TPM operations take as long as 80 seconds. I recommend 2
minutes.

nit: 'static' not necessary in anonymous namespace

[Denis Kuznetsov (DE-MUC), 2014-08-20 18:49:46]

https://chromiumcodereview.appspot.com/491913002/diff/1/chromeos/dbus/cryptoh...
File chromeos/dbus/cryptohome_client.cc (right):

https://chromiumcodereview.appspot.com/491913002/diff/1/chromeos/dbus/cryptoh...
chromeos/dbus/cryptohome_client.cc:31: static const int kTpmDBusTimeoutMs = 60 *
1000;
On 2014/08/20 17:32:05, Darren Krahn wrote:
> Where does 1 minute come from, is there data to support it?
> 
> We've seen some TPM operations take as long as 80 seconds. I recommend 2
> minutes.
> 
> nit: 'static' not necessary in anonymous namespace

https://code.google.com/p/chromium/issues/detail?id=378338#c63 mentioned one
minute.
I've updated it to two minutes.

[Darren Krahn, 2014-08-20 18:58:14]

On 2014/08/20 18:49:46, Denis Kuznetsov wrote:
>
https://chromiumcodereview.appspot.com/491913002/diff/1/chromeos/dbus/cryptoh...
> File chromeos/dbus/cryptohome_client.cc (right):
> 
>
https://chromiumcodereview.appspot.com/491913002/diff/1/chromeos/dbus/cryptoh...
> chromeos/dbus/cryptohome_client.cc:31: static const int kTpmDBusTimeoutMs = 60
*
> 1000;
> On 2014/08/20 17:32:05, Darren Krahn wrote:
> > Where does 1 minute come from, is there data to support it?
> > 
> > We've seen some TPM operations take as long as 80 seconds. I recommend 2
> > minutes.
> > 
> > nit: 'static' not necessary in anonymous namespace
> 
> https://code.google.com/p/chromium/issues/detail?id=378338#c63 mentioned one
> minute.
> I've updated it to two minutes.

lgtm (note: the CL description still says 1 minute)

[Denis Kuznetsov (DE-MUC), 2014-08-21 10:41:18]

The CQ bit was checked by antrim@chromium.org

[commit-bot: I haz the power, 2014-08-21 10:41:58]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/antrim@chromium.org/491913002/20001

[commit-bot: I haz the power, 2014-08-21 15:37:39]

Committed patchset #2 (20001) as 291080