Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 491903002: Dump out more information if this assert fails. (Closed)

Created:
6 years, 4 months ago by mtklein_C
Modified:
6 years, 4 months ago
Reviewers:
mtklein, caryclark, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : fix chrome canary #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/core/SkRecorder.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (0 generated)
mtklein
6 years, 4 months ago (2014-08-20 16:14:11 UTC) #1
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 4 months ago (2014-08-20 16:14:14 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/491903002/1
6 years, 4 months ago (2014-08-20 16:14:47 UTC) #3
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 4 months ago (2014-08-20 16:14:48 UTC) #4
reed1
lgtm
6 years, 4 months ago (2014-08-20 16:16:28 UTC) #5
caryclark
The CQ bit was checked by caryclark@google.com
6 years, 4 months ago (2014-08-20 16:18:22 UTC) #6
caryclark
lgtm
6 years, 4 months ago (2014-08-20 16:18:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/491903002/1
6 years, 4 months ago (2014-08-20 16:18:27 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (1) as ec924b9696277df4c684e73315194482e1d43e50
6 years, 4 months ago (2014-08-20 16:22:35 UTC) #9
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 4 months ago (2014-08-20 16:36:16 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/491903002/20001
6 years, 4 months ago (2014-08-20 16:36:58 UTC) #11
commit-bot: I haz the power
6 years, 4 months ago (2014-08-20 16:44:41 UTC) #12
Message was sent while issue was closed. 
Committed patchset #2 (20001) as 46bc6217ca41178c357a68be2869b8b2f6defe47

Powered by Google App Engine
This is Rietveld 408576698