Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 491893002: Handle bionic in safe_strerror_posix as well as glibc. (Closed)

Created:
6 years, 4 months ago by Torne
Modified:
6 years, 4 months ago
Reviewers:
brettw
CC:
chromium-reviews, erikwright+watch_chromium.org, enh
Project:
chromium
Visibility:
Public.

Description

Handle bionic in safe_strerror_posix as well as glibc. Android's bionic C library is intending to adopt the same semantics as glibc for strerror_r: define the version that returns char* if the source is compiled with _GNU_SOURCE instead of the POSIX version which returns int. Add __BIONIC__ to the condition for USE_HISTORICAL_STRERRO_R so that Chromium will still work. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291050

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M base/safe_strerror_posix.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Torne
Hi Brett, enh@ is intending to add gnu-compatible strerror_r to bionic (https://android-review.googlesource.com/#/c/104683/) and we will ...
6 years, 4 months ago (2014-08-20 16:04:12 UTC) #1
brettw
lgtm
6 years, 4 months ago (2014-08-20 22:28:54 UTC) #2
Torne
The CQ bit was checked by torne@chromium.org
6 years, 4 months ago (2014-08-21 11:09:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/torne@chromium.org/491893002/1
6 years, 4 months ago (2014-08-21 11:10:37 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-21 12:05:45 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (1) as 291050

Powered by Google App Engine
This is Rietveld 408576698