Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issue 491873004: Add an explicit full-screen button. (Closed)

Created:
6 years, 4 months ago by Jamie
Modified:
6 years, 3 months ago
Reviewers:
kelvinp
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@webapp_move_context_menu
Project:
chromium
Visibility:
Public.

Description

Add an explicit full-screen button. We've recevied feedback that conflating maximized and full-screen is not what users expect. This CL builds on https://codereview.chromium.org/498813003/ to remove this functionality and instead add an explicit full-screen button to the window frame. Note that the icon is a placeholder until we can get UX resources to design a better one. BUG=404693 Committed: https://crrev.com/0bc497a8815f2142907a9609d261d30d7d13aefa Cr-Commit-Position: refs/heads/master@{#291811}

Patch Set 1 #

Patch Set 2 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -62 lines) Patch
M remoting/remoting_webapp_files.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download
A remoting/resources/icon_fullscreen.webp View Binary file 0 comments Download
M remoting/webapp/client_session.js View 1 2 chunks +0 lines, -2 lines 0 comments Download
M remoting/webapp/fullscreen.js View 1 chunk +0 lines, -14 lines 0 comments Download
M remoting/webapp/fullscreen_v1.js View 1 chunk +0 lines, -3 lines 0 comments Download
M remoting/webapp/fullscreen_v2.js View 3 chunks +0 lines, -33 lines 0 comments Download
M remoting/webapp/html/window_frame.html View 1 chunk +4 lines, -0 lines 0 comments Download
M remoting/webapp/window_frame.css View 3 chunks +8 lines, -1 line 0 comments Download
M remoting/webapp/window_frame.js View 1 3 chunks +1 line, -9 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Jamie
jamiewalch@chromium.org changed reviewers: + kelvinp@chromium.org
6 years, 4 months ago (2014-08-25 18:18:01 UTC) #1
Jamie
ptal
6 years, 4 months ago (2014-08-25 18:18:02 UTC) #2
kelvinp
lgtm
6 years, 4 months ago (2014-08-25 19:05:10 UTC) #3
Jamie
The CQ bit was checked by jamiewalch@chromium.org
6 years, 4 months ago (2014-08-25 21:52:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamiewalch@chromium.org/491873004/20001
6 years, 4 months ago (2014-08-25 21:53:19 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (20001) as e1f924b936739b21e0ac9c53cff3ffc5cfe2c69b
6 years, 4 months ago (2014-08-26 00:34:02 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:39:23 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0bc497a8815f2142907a9609d261d30d7d13aefa
Cr-Commit-Position: refs/heads/master@{#291811}

Powered by Google App Engine
This is Rietveld 408576698