Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1001)

Issue 491843002: Blacklist %InternalSetProperty from runtime test fuzzing. (Closed)

Created:
6 years, 4 months ago by Yang
Modified:
6 years, 4 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Blacklist %InternalSetProperty from runtime test fuzzing. R=verwaest@chromium.org BUG=405499 LOG=N Committed: https://code.google.com/p/v8/source/detail?r=23230

Patch Set 1 #

Patch Set 2 : black list instead #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -8 lines) Patch
D test/mjsunit/runtime-gen/internalsetprototype.js View 1 1 chunk +0 lines, -6 lines 0 comments Download
M tools/generate-runtime-tests.py View 1 2 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Yang
6 years, 4 months ago (2014-08-20 12:31:52 UTC) #1
Toon Verwaest
Just blacklist the method instead, and mark the issue as "WontFix". This is a hack ...
6 years, 4 months ago (2014-08-20 12:40:46 UTC) #2
Toon Verwaest
lgtm
6 years, 4 months ago (2014-08-20 12:51:14 UTC) #3
Yang
6 years, 4 months ago (2014-08-20 12:51:55 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as 23230 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698