|
|
DescriptionModify test case to support streaming operation in sandbox file system.
BUG=360088
TEST=content_unittests passed
Committed: https://crrev.com/b146506ba947346179a58439459848bb5ef2e048
Cr-Commit-Position: refs/heads/master@{#292358}
Patch Set 1 #
Total comments: 2
Patch Set 2 : #Patch Set 3 : #Patch Set 4 : #Patch Set 5 : #Patch Set 6 : #Patch Set 7 : #
Messages
Total messages: 31 (0 generated)
Please take a look.
LGTM!
The CQ bit was checked by iseki@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/iseki@chromium.org/491813002/1
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel_swarming on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...) win_chromium_x64_rel_swarming on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_swarming on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by iseki@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/iseki@chromium.org/491813002/1
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel_swarming on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...) win_chromium_x64_rel_swarming on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_x64_rel_swarming on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
https://codereview.chromium.org/491813002/diff/1/content/browser/fileapi/file... File content/browser/fileapi/file_system_operation_impl_unittest.cc (right): https://codereview.chromium.org/491813002/diff/1/content/browser/fileapi/file... content/browser/fileapi/file_system_operation_impl_unittest.cc:281: base::MessageLoop message_loop_; This should be MessageLoopForIO now. That causes the test failure on Windows.
The CQ bit was checked by iseki@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/iseki@chromium.org/491813002/40001
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel_swarming on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...) win_chromium_x64_rel_swarming on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
Thank you for your advice. https://codereview.chromium.org/491813002/diff/1/content/browser/fileapi/file... File content/browser/fileapi/file_system_operation_impl_unittest.cc (right): https://codereview.chromium.org/491813002/diff/1/content/browser/fileapi/file... content/browser/fileapi/file_system_operation_impl_unittest.cc:281: base::MessageLoop message_loop_; On 2014/08/25 07:59:20, tzik wrote: > This should be MessageLoopForIO now. That causes the test failure on Windows. Done.
The CQ bit was checked by iseki@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/iseki@chromium.org/491813002/60001
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel_swarming on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...) win_chromium_x64_rel_swarming on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by iseki@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/iseki@chromium.org/491813002/80001
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_chromium_rel_swarming on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...) win_chromium_rel_swarming on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...) win_chromium_x64_rel_swarming on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_x64_rel_swarming on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by iseki@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/iseki@chromium.org/491813002/100001
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu_trigger...) win_chromium_rel_swarming on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as 2332db94ec6c42aaa3d66f5226a4c17b85c1553e
Message was sent while issue was closed.
A revert of this CL (patchset #6) has been created in https://codereview.chromium.org/510323003/ by mlamouri@chromium.org. The reason for reverting is: This is breaking fast/filesystem/op-copy.html in Blink: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40....
Message was sent while issue was closed.
Patchset 7 (id:??) landed as https://crrev.com/b146506ba947346179a58439459848bb5ef2e048 Cr-Commit-Position: refs/heads/master@{#292358} |