Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 491813002: Modify test case to support streaming operation in sandbox file system. (Closed)

Created:
6 years, 4 months ago by iseki
Modified:
6 years, 3 months ago
Reviewers:
tzik
CC:
chromium-reviews, darin-cc_chromium.org, jam, kinuko+fileapi, nhiroki, tzik
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Modify test case to support streaming operation in sandbox file system. BUG=360088 TEST=content_unittests passed Committed: https://crrev.com/b146506ba947346179a58439459848bb5ef2e048 Cr-Commit-Position: refs/heads/master@{#292358}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -11 lines) Patch
M content/browser/fileapi/file_system_operation_impl_unittest.cc View 1 2 3 4 5 6 7 chunks +13 lines, -9 lines 0 comments Download
M content/browser/fileapi/obfuscated_file_util_unittest.cc View 1 2 3 4 5 1 chunk +2 lines, -1 line 0 comments Download
M webkit/browser/fileapi/sandbox_file_system_backend.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 31 (0 generated)
iseki
Please take a look.
6 years, 4 months ago (2014-08-20 10:43:15 UTC) #1
tzik
LGTM!
6 years, 4 months ago (2014-08-21 07:02:18 UTC) #2
iseki
The CQ bit was checked by iseki@chromium.org
6 years, 4 months ago (2014-08-21 07:08:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/iseki@chromium.org/491813002/1
6 years, 4 months ago (2014-08-21 07:08:47 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel_swarming on tryserver.chromium.win ...
6 years, 4 months ago (2014-08-21 13:09:58 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-21 13:57:53 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_swarming on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_swarming/builds/4178)
6 years, 4 months ago (2014-08-21 13:57:54 UTC) #7
iseki
The CQ bit was checked by iseki@chromium.org
6 years, 4 months ago (2014-08-22 00:31:49 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/iseki@chromium.org/491813002/1
6 years, 4 months ago (2014-08-22 00:33:23 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel_swarming on tryserver.chromium.win ...
6 years, 4 months ago (2014-08-22 01:46:32 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-22 02:39:59 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_swarming on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_swarming/builds/1909)
6 years, 4 months ago (2014-08-22 02:40:00 UTC) #12
tzik
https://codereview.chromium.org/491813002/diff/1/content/browser/fileapi/file_system_operation_impl_unittest.cc File content/browser/fileapi/file_system_operation_impl_unittest.cc (right): https://codereview.chromium.org/491813002/diff/1/content/browser/fileapi/file_system_operation_impl_unittest.cc#newcode281 content/browser/fileapi/file_system_operation_impl_unittest.cc:281: base::MessageLoop message_loop_; This should be MessageLoopForIO now. That causes ...
6 years, 4 months ago (2014-08-25 07:59:21 UTC) #13
iseki
The CQ bit was checked by iseki@chromium.org
6 years, 4 months ago (2014-08-25 08:47:49 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/iseki@chromium.org/491813002/40001
6 years, 4 months ago (2014-08-25 08:48:32 UTC) #15
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel_swarming on tryserver.chromium.win ...
6 years, 4 months ago (2014-08-25 10:06:45 UTC) #16
iseki
Thank you for your advice. https://codereview.chromium.org/491813002/diff/1/content/browser/fileapi/file_system_operation_impl_unittest.cc File content/browser/fileapi/file_system_operation_impl_unittest.cc (right): https://codereview.chromium.org/491813002/diff/1/content/browser/fileapi/file_system_operation_impl_unittest.cc#newcode281 content/browser/fileapi/file_system_operation_impl_unittest.cc:281: base::MessageLoop message_loop_; On 2014/08/25 ...
6 years, 4 months ago (2014-08-25 10:28:23 UTC) #17
iseki
The CQ bit was checked by iseki@chromium.org
6 years, 4 months ago (2014-08-25 10:28:47 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/iseki@chromium.org/491813002/60001
6 years, 4 months ago (2014-08-25 10:29:55 UTC) #19
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel_swarming on tryserver.chromium.win ...
6 years, 4 months ago (2014-08-25 11:37:06 UTC) #20
iseki
The CQ bit was checked by iseki@chromium.org
6 years, 4 months ago (2014-08-25 12:06:16 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/iseki@chromium.org/491813002/80001
6 years, 4 months ago (2014-08-25 12:06:54 UTC) #22
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_chromium_rel_swarming on tryserver.chromium.mac ...
6 years, 4 months ago (2014-08-25 13:52:02 UTC) #23
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-25 14:31:22 UTC) #24
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_swarming on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_swarming/builds/2500)
6 years, 4 months ago (2014-08-25 14:31:23 UTC) #25
iseki
The CQ bit was checked by iseki@chromium.org
6 years, 3 months ago (2014-08-28 08:23:57 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/iseki@chromium.org/491813002/100001
6 years, 3 months ago (2014-08-28 08:25:11 UTC) #27
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_gpu_triggered_tests on tryserver.chromium.gpu ...
6 years, 3 months ago (2014-08-28 09:23:03 UTC) #28
commit-bot: I haz the power
Committed patchset #6 (id:100001) as 2332db94ec6c42aaa3d66f5226a4c17b85c1553e
6 years, 3 months ago (2014-08-28 10:39:05 UTC) #29
mlamouri (slow - plz ping)
A revert of this CL (patchset #6) has been created in https://codereview.chromium.org/510323003/ by mlamouri@chromium.org. The ...
6 years, 3 months ago (2014-08-28 12:14:51 UTC) #30
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:58:48 UTC) #31
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/b146506ba947346179a58439459848bb5ef2e048
Cr-Commit-Position: refs/heads/master@{#292358}

Powered by Google App Engine
This is Rietveld 408576698