Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 491793003: Benchmark designed to exercise fractional image scale/translation (Closed)

Created:
6 years, 4 months ago by humper
Modified:
6 years, 4 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Benchmark designed to exercise fractional image scale/translation BUG=skia: Committed: https://skia.googlesource.com/skia/+/5fc226641a0926dddbf70ba784f344881f4c05b9

Patch Set 1 #

Total comments: 1

Patch Set 2 : Nits, add downscaling, and add low/medium/high versions #

Unified diffs Side-by-side diffs Delta from patch set Stats (+105 lines, -0 lines) Patch
A bench/BitmapFractionalBench.cpp View 1 1 chunk +104 lines, -0 lines 0 comments Download
M gyp/bench.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
humper
ptal
6 years, 4 months ago (2014-08-25 16:29:07 UTC) #1
reed1
lgtm, though perhaps it can be redone to scale down, and then we could also ...
6 years, 4 months ago (2014-08-25 17:10:15 UTC) #2
humper
On 2014/08/25 17:10:15, reed1 wrote: > lgtm, though perhaps it can be redone to scale ...
6 years, 4 months ago (2014-08-25 18:10:00 UTC) #3
humper
The CQ bit was checked by humper@google.com
6 years, 4 months ago (2014-08-25 18:10:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/humper@google.com/491793003/20001
6 years, 4 months ago (2014-08-25 18:10:47 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (20001) as 5fc226641a0926dddbf70ba784f344881f4c05b9
6 years, 4 months ago (2014-08-25 18:17:52 UTC) #6
djsollen
6 years, 4 months ago (2014-08-25 19:02:06 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #2) has been created in
https://codereview.chromium.org/470063007/ by djsollen@google.com.

The reason for reverting is: fires asserts on Linux Debug builds

http://108.170.220.120:10115/builders/Test-Ubuntu12-ShuttleA-GTX660-x86_64-De....

Powered by Google App Engine
This is Rietveld 408576698