Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Unified Diff: components/domain_reliability/service.cc

Issue 491753003: Domain Reliability: Don't upload when metrics reporting is off. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Make sure constructor and destructor are on correct threads. Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/domain_reliability/service.cc
diff --git a/components/domain_reliability/service.cc b/components/domain_reliability/service.cc
index 4d675733aaed5ae0ff5ba04fe79f8f5935ab2588..3224b64f19f032288dafadb35e8815d2c7c2e11a 100644
--- a/components/domain_reliability/service.cc
+++ b/components/domain_reliability/service.cc
@@ -6,6 +6,7 @@
#include "base/bind.h"
#include "base/callback.h"
+#include "base/message_loop/message_loop_proxy.h"
#include "base/single_thread_task_runner.h"
#include "base/task_runner_util.h"
#include "components/domain_reliability/monitor.h"
@@ -39,11 +40,17 @@ class DomainReliabilityServiceImpl : public DomainReliabilityService {
// DomainReliabilityService implementation:
virtual scoped_ptr<DomainReliabilityMonitor> CreateMonitor(
- scoped_refptr<base::SequencedTaskRunner> network_task_runner) OVERRIDE {
+ scoped_refptr<base::SingleThreadTaskRunner> network_task_runner,
+ PrefService* local_state_pref_service,
+ const char* reporting_pref_name) OVERRIDE {
DCHECK(!network_task_runner_);
scoped_ptr<DomainReliabilityMonitor> monitor(
- new DomainReliabilityMonitor(upload_reporter_string_));
+ new DomainReliabilityMonitor(upload_reporter_string_,
+ base::MessageLoopProxy::current(),
+ network_task_runner,
+ local_state_pref_service,
+ reporting_pref_name));
monitor_ = monitor->MakeWeakPtr();
network_task_runner_ = network_task_runner;
@@ -78,7 +85,7 @@ class DomainReliabilityServiceImpl : public DomainReliabilityService {
private:
std::string upload_reporter_string_;
base::WeakPtr<DomainReliabilityMonitor> monitor_;
- scoped_refptr<base::SequencedTaskRunner> network_task_runner_;
+ scoped_refptr<base::SingleThreadTaskRunner> network_task_runner_;
};
// static

Powered by Google App Engine
This is Rietveld 408576698