Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1075)

Unified Diff: components/domain_reliability/uploader_unittest.cc

Issue 491753003: Domain Reliability: Don't upload when metrics reporting is off. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix pref handling Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/domain_reliability/uploader_unittest.cc
diff --git a/components/domain_reliability/uploader_unittest.cc b/components/domain_reliability/uploader_unittest.cc
index 362b202b50653220eac6bd6bc1fb043b906dee01..3581ef089157b8a143ec355bd47696bc5c289eba 100644
--- a/components/domain_reliability/uploader_unittest.cc
+++ b/components/domain_reliability/uploader_unittest.cc
@@ -28,7 +28,9 @@ class DomainReliabilityUploaderTest : public testing::Test {
url_request_context_getter_(new net::TestURLRequestContextGetter(
network_task_runner_)),
uploader_(DomainReliabilityUploader::Create(
- url_request_context_getter_)) {}
+ url_request_context_getter_)) {
+ uploader_->set_discard_uploads(false);
+ }
DomainReliabilityUploader::UploadCallback MakeUploadCallback(size_t index) {
return base::Bind(&DomainReliabilityUploaderTest::OnUploadComplete,
@@ -108,5 +110,18 @@ TEST_F(DomainReliabilityUploaderTest, FailedUpload) {
EXPECT_FALSE(upload_successful_[0]);
}
+TEST_F(DomainReliabilityUploaderTest, DiscardedUpload) {
+ net::TestURLFetcher* fetcher;
+
+ uploader_->set_discard_uploads(true);
+
+ std::string report_json = "{}";
+ GURL upload_url = GURL("https://example/upload");
+ uploader_->UploadReport(report_json, upload_url, MakeUploadCallback(0));
+
+ fetcher = url_fetcher_factory_.GetFetcherByID(0);
+ EXPECT_FALSE(fetcher);
+}
+
} // namespace
} // namespace domain_reliability
« components/domain_reliability/monitor.cc ('K') | « components/domain_reliability/uploader.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698