Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(386)

Unified Diff: components/domain_reliability/uploader.cc

Issue 491753003: Domain Reliability: Don't upload when metrics reporting is off. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix pref handling Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/domain_reliability/uploader.cc
diff --git a/components/domain_reliability/uploader.cc b/components/domain_reliability/uploader.cc
index 5fd35a30cce5c182bb44329d543ecb8403796455..d382914cc0858badc1538e322b545f79a1ddac0a 100644
--- a/components/domain_reliability/uploader.cc
+++ b/components/domain_reliability/uploader.cc
@@ -43,7 +43,8 @@ class DomainReliabilityUploaderImpl
public:
DomainReliabilityUploaderImpl(const scoped_refptr<
net::URLRequestContextGetter>& url_request_context_getter)
- : url_request_context_getter_(url_request_context_getter) {}
+ : url_request_context_getter_(url_request_context_getter),
+ discard_uploads_(true) {}
virtual ~DomainReliabilityUploaderImpl() {
// Delete any in-flight URLFetchers.
@@ -59,6 +60,12 @@ class DomainReliabilityUploaderImpl
VLOG(1) << "Uploading report to " << upload_url;
VLOG(2) << "Report JSON: " << report_json;
+ if (discard_uploads_) {
+ VLOG(1) << "Discarding report instead of uploading.";
+ callback.Run(true);
+ return;
+ }
+
net::URLFetcher* fetcher =
net::URLFetcher::Create(0, upload_url, net::URLFetcher::POST, this);
fetcher->SetRequestContext(url_request_context_getter_);
@@ -74,6 +81,11 @@ class DomainReliabilityUploaderImpl
upload_callbacks_[fetcher] = callback;
}
+ virtual void set_discard_uploads(bool discard_uploads) OVERRIDE {
+ discard_uploads_ = discard_uploads;
+ VLOG(1) << "Setting discard_uploads to " << discard_uploads;
+ }
+
// net::URLFetcherDelegate implementation:
virtual void OnURLFetchComplete(
const net::URLFetcher* fetcher) OVERRIDE {
@@ -100,6 +112,7 @@ class DomainReliabilityUploaderImpl
scoped_refptr<net::URLRequestContextGetter> url_request_context_getter_;
UploadCallbackMap upload_callbacks_;
+ bool discard_uploads_;
};
} // namespace

Powered by Google App Engine
This is Rietveld 408576698