Domain Reliability: Don't upload when metrics reporting is off.

components/domain_reliability/monitor.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_DOMAIN_RELIABILITY_MONITOR_H_
 #define COMPONENTS_DOMAIN_RELIABILITY_MONITOR_H_
 
 #include <map>
 
 #include "base/memory/ref_counted.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/memory/weak_ptr.h"
+#include "base/prefs/pref_member.h"
 #include "base/time/time.h"
 #include "components/domain_reliability/beacon.h"
 #include "components/domain_reliability/clear_mode.h"
 #include "components/domain_reliability/config.h"
 #include "components/domain_reliability/context.h"
 #include "components/domain_reliability/dispatcher.h"
 #include "components/domain_reliability/domain_reliability_export.h"
 #include "components/domain_reliability/scheduler.h"
 #include "components/domain_reliability/uploader.h"
 #include "components/domain_reliability/util.h"
 #include "net/base/load_timing_info.h"
 #include "net/http/http_response_info.h"
 #include "net/url_request/url_request_status.h"
 
+class PrefService;
+
 namespace base {
 class SingleThreadTaskRunner;
 class ThreadChecker;
 class Value;
 }  // namespace base
 
 namespace net {
 class URLRequest;
 class URLRequestContext;
 class URLRequestContextGetter;
 }  // namespace net
 
 namespace domain_reliability {
 
 // The top-level object that measures requests and hands off the measurements
 // to the proper |DomainReliabilityContext|.
 class DOMAIN_RELIABILITY_EXPORT DomainReliabilityMonitor {
  public:
-  explicit DomainReliabilityMonitor(const std::string& upload_reporter_string);
+  DomainReliabilityMonitor(const std::string& upload_reporter_string);
   DomainReliabilityMonitor(const std::string& upload_reporter_string,
                            scoped_ptr<MockableTime> time);
   ~DomainReliabilityMonitor();
 
-  // Initializes the Monitor.
-  void Init(
+  // Initializes the Monitor's pref member that monitors the reporting pref.

[davidben, 2014/08/20 21:49:03]

Could you document the threading requirements of all these init methods? I've
since forgotten how this code is initialized and am a little confused.
InitReportingPref is called first and then called on the UI thread (or whatever
the generic name for it is... the thread a PrefService lives on)? And then
|network_message_loop_proxy| is where it'll live from now on, and
InitURLRequestContext is required to be called on that task runner? (Which then
is the one it's passed in?)

It would probably helpful if InitReportingPref were hooked up so I could see how
it's supposed to fit together.

[Deprecated (see juliatuttle), 2014/08/21 18:35:28]

Done.

+  void InitReportingPref(
+      PrefService* local_state_pref_service,
+      const char* reporting_pref_name,
+      const scoped_refptr<base::SingleThreadTaskRunner>&
+          network_message_loop_proxy);

[davidben, 2014/08/20 21:49:03]

s/message_loop_proxy/task_runner/?

[Deprecated (see juliatuttle), 2014/08/21 18:35:28]

Done.

+
+  // Initializes the Monitor's URLRequestContextGetter.
+  void InitURLRequestContext(
       net::URLRequestContext* url_request_context,
       const scoped_refptr<base::SingleThreadTaskRunner>& task_runner);
 
   // Same, but for unittests where the Getter is readily available.
-  void Init(
+  void InitURLRequestContext(
       scoped_refptr<net::URLRequestContextGetter> url_request_context_getter);
 
   // Populates the monitor with contexts that were configured at compile time.
   void AddBakedInConfigs();
 
   // Should be called when |request| is about to follow a redirect. Will
   // examine and possibly log the redirect request.
   void OnBeforeRedirect(net::URLRequest* request);
 
   // Should be called when |request| is complete. Will examine and possibly
@@ skipping 38 matching lines @@
   };
 
   // Creates a context, adds it to the monitor, and returns a pointer to it.
   // (The pointer is only valid until the Monitor is destroyed.)
   DomainReliabilityContext* AddContext(
       scoped_ptr<const DomainReliabilityConfig> config);
   // Deletes all contexts from |contexts_| and clears the map.
   void ClearContexts();
   void OnRequestLegComplete(const RequestInfo& info);
 
+  void OnReportingPrefChanged();
+
   DomainReliabilityContext* GetContextForHost(const std::string& host) const;
 
   base::WeakPtr<DomainReliabilityMonitor> MakeWeakPtr();
 
   scoped_ptr<base::ThreadChecker> thread_checker_;
   scoped_ptr<MockableTime> time_;
   const std::string upload_reporter_string_;
   DomainReliabilityScheduler::Params scheduler_params_;
   DomainReliabilityDispatcher dispatcher_;
   scoped_ptr<DomainReliabilityUploader> uploader_;
   ContextMap contexts_;
 
+  const char* reporting_pref_name_;
+  BooleanPrefMember reporting_pref_;
+  bool reporting_pref_initialized_;
+
   base::WeakPtrFactory<DomainReliabilityMonitor> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(DomainReliabilityMonitor);
 };
 
 }  // namespace domain_reliability
 
 #endif  // COMPONENTS_DOMAIN_RELIABILITY_MONITOR_H_