Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Side by Side Diff: components/domain_reliability/monitor_unittest.cc

Issue 491753003: Domain Reliability: Don't upload when metrics reporting is off. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix pref handling Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/domain_reliability/monitor.h" 5 #include "components/domain_reliability/monitor.h"
6 6
7 #include <map> 7 #include <map>
8 #include <string> 8 #include <string>
9 #include <vector> 9 #include <vector>
10 10
11 #include "base/bind.h" 11 #include "base/bind.h"
12 #include "base/memory/scoped_ptr.h" 12 #include "base/memory/scoped_ptr.h"
13 #include "base/message_loop/message_loop_proxy.h" 13 #include "base/message_loop/message_loop_proxy.h"
14 #include "base/prefs/pref_registry_simple.h"
15 #include "base/prefs/testing_pref_service.h"
14 #include "base/test/test_simple_task_runner.h" 16 #include "base/test/test_simple_task_runner.h"
15 #include "components/domain_reliability/baked_in_configs.h" 17 #include "components/domain_reliability/baked_in_configs.h"
16 #include "components/domain_reliability/beacon.h" 18 #include "components/domain_reliability/beacon.h"
17 #include "components/domain_reliability/config.h" 19 #include "components/domain_reliability/config.h"
18 #include "components/domain_reliability/test_util.h" 20 #include "components/domain_reliability/test_util.h"
19 #include "net/base/host_port_pair.h" 21 #include "net/base/host_port_pair.h"
20 #include "net/base/load_flags.h" 22 #include "net/base/load_flags.h"
21 #include "net/http/http_response_headers.h" 23 #include "net/http/http_response_headers.h"
22 #include "net/http/http_util.h" 24 #include "net/http/http_util.h"
23 #include "net/url_request/url_request_context_getter.h" 25 #include "net/url_request/url_request_context_getter.h"
24 #include "net/url_request/url_request_status.h" 26 #include "net/url_request/url_request_status.h"
25 #include "net/url_request/url_request_test_util.h" 27 #include "net/url_request/url_request_test_util.h"
26 #include "testing/gtest/include/gtest/gtest.h" 28 #include "testing/gtest/include/gtest/gtest.h"
27 29
28 namespace domain_reliability { 30 namespace domain_reliability {
29 31
30 namespace { 32 namespace {
31 33
32 typedef std::vector<DomainReliabilityBeacon> BeaconVector; 34 typedef std::vector<DomainReliabilityBeacon> BeaconVector;
33 35
34 static const size_t kAlwaysReportIndex = 0u; 36 static const size_t kAlwaysReportIndex = 0u;
35 static const size_t kNeverReportIndex = 1u; 37 static const size_t kNeverReportIndex = 1u;
36 38
39 static const char* kPrefName = "reporting_enabled";
40
37 scoped_refptr<net::HttpResponseHeaders> MakeHttpResponseHeaders( 41 scoped_refptr<net::HttpResponseHeaders> MakeHttpResponseHeaders(
38 const std::string& headers) { 42 const std::string& headers) {
39 return scoped_refptr<net::HttpResponseHeaders>( 43 return scoped_refptr<net::HttpResponseHeaders>(
40 new net::HttpResponseHeaders(net::HttpUtil::AssembleRawHeaders( 44 new net::HttpResponseHeaders(net::HttpUtil::AssembleRawHeaders(
41 headers.c_str(), headers.length()))); 45 headers.c_str(), headers.length())));
42 } 46 }
43 47
44 } // namespace 48 } // namespace
45 49
46 class DomainReliabilityMonitorTest : public testing::Test { 50 class DomainReliabilityMonitorTest : public testing::Test {
47 protected: 51 protected:
48 typedef DomainReliabilityMonitor::RequestInfo RequestInfo; 52 typedef DomainReliabilityMonitor::RequestInfo RequestInfo;
49 53
50 DomainReliabilityMonitorTest() 54 DomainReliabilityMonitorTest()
51 : network_task_runner_(new base::TestSimpleTaskRunner()), 55 : network_task_runner_(new base::TestSimpleTaskRunner()),
52 url_request_context_getter_( 56 url_request_context_getter_(
53 new net::TestURLRequestContextGetter(network_task_runner_)), 57 new net::TestURLRequestContextGetter(network_task_runner_)),
54 time_(new MockTime()), 58 time_(new MockTime()),
55 monitor_("test-reporter", scoped_ptr<MockableTime>(time_)), 59 monitor_("test-reporter", scoped_ptr<MockableTime>(time_)),
56 context_(NULL) { 60 context_(NULL) {
57 monitor_.Init(url_request_context_getter_); 61 // This will block uploads, but there's no test for whether uploads happen.
62 // TODO(ttuttle): Test that uploads actually happen.
63 pref_service_.registry()->RegisterBooleanPref(kPrefName, false);
64 pref_service_.SetUserPref(kPrefName, new base::FundamentalValue(true));
65 monitor_.InitReportingPref(
66 &pref_service_, kPrefName, network_task_runner_);
67 monitor_.InitURLRequestContext(url_request_context_getter_);
58 context_ = monitor_.AddContextForTesting(MakeTestConfig()); 68 context_ = monitor_.AddContextForTesting(MakeTestConfig());
59 } 69 }
60 70
61 static RequestInfo MakeRequestInfo() { 71 static RequestInfo MakeRequestInfo() {
62 RequestInfo request; 72 RequestInfo request;
63 request.status = net::URLRequestStatus(); 73 request.status = net::URLRequestStatus();
64 request.status.set_status(net::URLRequestStatus::SUCCESS); 74 request.status.set_status(net::URLRequestStatus::SUCCESS);
65 request.status.set_error(net::OK); 75 request.status.set_error(net::OK);
66 request.response_info.socket_address = 76 request.response_info.socket_address =
67 net::HostPortPair::FromString("12.34.56.78:80"); 77 net::HostPortPair::FromString("12.34.56.78:80");
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
104 return expected_successful == successful && expected_failed == failed; 114 return expected_successful == successful && expected_failed == failed;
105 } 115 }
106 116
107 DomainReliabilityContext* CreateAndAddContext(const std::string& domain) { 117 DomainReliabilityContext* CreateAndAddContext(const std::string& domain) {
108 return monitor_.AddContextForTesting(MakeTestConfigWithDomain(domain)); 118 return monitor_.AddContextForTesting(MakeTestConfigWithDomain(domain));
109 } 119 }
110 120
111 scoped_refptr<base::TestSimpleTaskRunner> network_task_runner_; 121 scoped_refptr<base::TestSimpleTaskRunner> network_task_runner_;
112 scoped_refptr<net::URLRequestContextGetter> url_request_context_getter_; 122 scoped_refptr<net::URLRequestContextGetter> url_request_context_getter_;
113 MockTime* time_; 123 MockTime* time_;
124 TestingPrefServiceSimple pref_service_;
114 DomainReliabilityMonitor monitor_; 125 DomainReliabilityMonitor monitor_;
115 DomainReliabilityContext* context_; 126 DomainReliabilityContext* context_;
116 DomainReliabilityMonitor::RequestInfo request_; 127 DomainReliabilityMonitor::RequestInfo request_;
117 }; 128 };
118 129
119 namespace { 130 namespace {
120 131
121 TEST_F(DomainReliabilityMonitorTest, Create) { 132 TEST_F(DomainReliabilityMonitorTest, Create) {
122 EXPECT_EQ(0u, CountPendingBeacons()); 133 EXPECT_EQ(0u, CountPendingBeacons());
123 EXPECT_TRUE(CheckRequestCounts(kAlwaysReportIndex, 0u, 0u)); 134 EXPECT_TRUE(CheckRequestCounts(kAlwaysReportIndex, 0u, 0u));
(...skipping 251 matching lines...) Expand 10 before | Expand all | Expand 10 after
375 request.url = GURL("http://test.wildcard/always_report"); 386 request.url = GURL("http://test.wildcard/always_report");
376 OnRequestLegComplete(request); 387 OnRequestLegComplete(request);
377 388
378 EXPECT_TRUE(CheckRequestCounts(context1, kAlwaysReportIndex, 1u, 0u)); 389 EXPECT_TRUE(CheckRequestCounts(context1, kAlwaysReportIndex, 1u, 0u));
379 EXPECT_TRUE(CheckRequestCounts(context2, kAlwaysReportIndex, 0u, 0u)); 390 EXPECT_TRUE(CheckRequestCounts(context2, kAlwaysReportIndex, 0u, 0u));
380 } 391 }
381 392
382 } // namespace 393 } // namespace
383 394
384 } // namespace domain_reliability 395 } // namespace domain_reliability
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698