[EasyUnlock] Add a private API for establishing an insecure Bluetooth connection.

[EasyUnlock] Add a private API for establishing an insecure Bluetooth connection.

This is needed to avoid a pairing request prompt when connecting to a service on
a system that tries to upgrade the connection from general bonding to general
bonding with MITM protection, which according to Android and ChromeOS Bluetooth
experts is the correct behavior.

BUG=403069
TEST=chrome.easyUnlockPrivate.connectToBluetoothServiceInsecurely() should work
     just like chrome.bluetoothSocket.connect(), but not show a pairing request
     prompt when pairing with Android L.
R=tengs@chromium.org, keybuk@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291353

[Ilya Sherman, 2014-08-20 22:12:56]

Tim, PTAL at the EasyUnlock changes.
Scott, PTAL at the Bluetooth changes.

[Tim Song, 2014-08-21 00:36:28]

LGTM for easyUnlockPrivate API.

Scott, do you think this would be worth moving to bluetoothPrivate instead?
We're the only ones who need this API at the moment and this seems like quite
the corner case.

https://chromiumcodereview.appspot.com/491753002/diff/20001/chrome/browser/ex...
File
chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api.cc
(right):

https://chromiumcodereview.appspot.com/491753002/diff/20001/chrome/browser/ex...
chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api.cc:417:
chromeos::BluetoothDeviceChromeOS* device_chromeos =
You can get rid of this ifdef and the #include above by moving this to
bluetooth_util*.cc.

https://chromiumcodereview.appspot.com/491753002/diff/20001/chrome/common/ext...
File chrome/common/extensions/api/easy_unlock_private.idl (right):

https://chromiumcodereview.appspot.com/491753002/diff/20001/chrome/common/ext...
chrome/common/extensions/api/easy_unlock_private.idl:218: // connection, i.e. a
connection that requests no bonding. Other than the
also mention "no MITM protection" as it's possible to request No Bonding, but
also require MITM protection (Android actually does this).

[Ilya Sherman, 2014-08-21 00:53:25]

https://chromiumcodereview.appspot.com/491753002/diff/20001/chrome/browser/ex...
File
chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api.cc
(right):

https://chromiumcodereview.appspot.com/491753002/diff/20001/chrome/browser/ex...
chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api.cc:417:
chromeos::BluetoothDeviceChromeOS* device_chromeos =
On 2014/08/21 00:36:27, Tim Song wrote:
> You can get rid of this ifdef and the #include above by moving this to
> bluetooth_util*.cc.

Yes, but then I have to pass extra callbacks to bluetooth_util*.cc.  I didn't
think it was worth it.  Let me know if you'd like me to change this.

https://chromiumcodereview.appspot.com/491753002/diff/20001/chrome/common/ext...
File chrome/common/extensions/api/easy_unlock_private.idl (right):

https://chromiumcodereview.appspot.com/491753002/diff/20001/chrome/common/ext...
chrome/common/extensions/api/easy_unlock_private.idl:218: // connection, i.e. a
connection that requests no bonding. Other than the
On 2014/08/21 00:36:27, Tim Song wrote:
> also mention "no MITM protection" as it's possible to request No Bonding, but
> also require MITM protection (Android actually does this).

Done.

[Tim Song, 2014-08-21 01:02:44]

https://chromiumcodereview.appspot.com/491753002/diff/20001/chrome/browser/ex...
File
chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api.cc
(right):

https://chromiumcodereview.appspot.com/491753002/diff/20001/chrome/browser/ex...
chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api.cc:417:
chromeos::BluetoothDeviceChromeOS* device_chromeos =
On 2014/08/21 00:53:24, Ilya Sherman wrote:
> On 2014/08/21 00:36:27, Tim Song wrote:
> > You can get rid of this ifdef and the #include above by moving this to
> > bluetooth_util*.cc.
> 
> Yes, but then I have to pass extra callbacks to bluetooth_util*.cc.  I didn't
> think it was worth it.  Let me know if you'd like me to change this.

I think it's cleaner to move it to the util file even though it's a bit more
code.

[keybuk, 2014-08-21 16:58:07]

lgtm

[Ilya Sherman, 2014-08-21 22:32:00]

Yoyo or Antony, PTAL at the extensions IDL file changes.  Thanks.

[Yoyo Zhou, 2014-08-21 22:42:53]

IDL lgtm

https://chromiumcodereview.appspot.com/491753002/diff/40001/chrome/common/ext...
File chrome/common/extensions/api/easy_unlock_private.idl (right):

https://chromiumcodereview.appspot.com/491753002/diff/40001/chrome/common/ext...
chrome/common/extensions/api/easy_unlock_private.idl:221: // |socketId| : The
socket identifier, as issued by the
nit: no space between | and :

https://chromiumcodereview.appspot.com/491753002/diff/40001/chrome/common/ext...
chrome/common/extensions/api/easy_unlock_private.idl:223: // |address| : The
address of the Bluetooth device.
Should this be called deviceAddress for consistency with
seekBluetoothDeviceByAddress? The doc string should be the same if so.

[Ilya Sherman, 2014-08-21 23:09:20]

The CQ bit was checked by isherman@chromium.org

[Ilya Sherman, 2014-08-21 23:11:30]

https://chromiumcodereview.appspot.com/491753002/diff/20001/chrome/browser/ex...
File
chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api.cc
(right):

https://chromiumcodereview.appspot.com/491753002/diff/20001/chrome/browser/ex...
chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api.cc:417:
chromeos::BluetoothDeviceChromeOS* device_chromeos =
On 2014/08/21 01:02:44, Tim Song wrote:
> On 2014/08/21 00:53:24, Ilya Sherman wrote:
> > On 2014/08/21 00:36:27, Tim Song wrote:
> > > You can get rid of this ifdef and the #include above by moving this to
> > > bluetooth_util*.cc.
> > 
> > Yes, but then I have to pass extra callbacks to bluetooth_util*.cc.  I
didn't
> > think it was worth it.  Let me know if you'd like me to change this.
> 
> I think it's cleaner to move it to the util file even though it's a bit more
> code.

Done.

https://chromiumcodereview.appspot.com/491753002/diff/40001/chrome/common/ext...
File chrome/common/extensions/api/easy_unlock_private.idl (right):

https://chromiumcodereview.appspot.com/491753002/diff/40001/chrome/common/ext...
chrome/common/extensions/api/easy_unlock_private.idl:221: // |socketId| : The
socket identifier, as issued by the
On 2014/08/21 22:42:53, Yoyo Zhou wrote:
> nit: no space between | and :

Done.

https://chromiumcodereview.appspot.com/491753002/diff/40001/chrome/common/ext...
chrome/common/extensions/api/easy_unlock_private.idl:223: // |address| : The
address of the Bluetooth device.
On 2014/08/21 22:42:52, Yoyo Zhou wrote:
> Should this be called deviceAddress for consistency with
> seekBluetoothDeviceByAddress? The doc string should be the same if so.

Done.

[commit-bot: I haz the power, 2014-08-21 23:11:39]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/isherman@chromium.org/491753002/60001

[commit-bot: I haz the power, 2014-08-22 00:10:22]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/44949)
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/50133)
  linux_chromium_gn_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win8_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)
  win_chromium_compile_dbg on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_chromium_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_chromium_x64_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[commit-bot: I haz the power, 2014-08-22 00:12:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-22 00:12:11]

Try jobs failed on following builders:
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/44974)
  linux_chromium_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Ilya Sherman, 2014-08-22 03:46:45]

The CQ bit was checked by isherman@chromium.org

[commit-bot: I haz the power, 2014-08-22 03:47:21]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/isherman@chromium.org/491753002/80001

[Ilya Sherman, 2014-08-22 03:48:14]

The CQ bit was checked by isherman@chromium.org

[commit-bot: I haz the power, 2014-08-22 03:49:11]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/isherman@chromium.org/491753002/100001

[commit-bot: I haz the power, 2014-08-22 04:48:13]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_chromium_gn_compile_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  android_dbg_tests_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)
  win_chromium_compile_dbg on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[commit-bot: I haz the power, 2014-08-22 04:54:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-22 04:54:31]

Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)

[Ilya Sherman, 2014-08-22 05:01:29]

The CQ bit was checked by isherman@chromium.org

[commit-bot: I haz the power, 2014-08-22 05:02:50]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/isherman@chromium.org/491753002/100001

[commit-bot: I haz the power, 2014-08-22 05:43:36]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_tests_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)

[commit-bot: I haz the power, 2014-08-22 07:32:33]

Committed patchset #6 (100001) as 291353