Adding tracing and gtest pretty printing support to TestPendingTask.

base/test/test_pending_task.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef BASE_TEST_TEST_PENDING_TASK_H_
 #define BASE_TEST_TEST_PENDING_TASK_H_
 
+#include <string>
+
 #include "base/callback.h"
+#include "base/debug/trace_event_argument.h"
 #include "base/location.h"
 #include "base/time/time.h"
 
 namespace base {
 
 // TestPendingTask is a helper class for test TaskRunner
 // implementations.  See test_simple_task_runner.h for example usage.
 
 struct TestPendingTask {
   enum TestNestability { NESTABLE, NON_NESTABLE };
@@ skipping 25 matching lines @@
   //
   //   - std::max_element
   //   - std::sort.
   bool ShouldRunBefore(const TestPendingTask& other) const;
 
   tracked_objects::Location location;
   Closure task;
   TimeTicks post_time;
   TimeDelta delay;
   TestNestability nestability;
+
+  // Functions for using test pending task with tracing, useful in unit
+  // testing.
+  void AsValueInto(base::debug::TracedValue* state) const;
+  scoped_refptr<base::debug::ConvertableToTraceFormat> AsValue() const;
+  std::string ToString() const;
 };
 
+// gtest helpers which allow pretty printing of the tasks, very useful in unit
+// testing.
+::std::ostream& operator<<(::std::ostream& os, const TestPendingTask& task);
+void PrintTo(const TestPendingTask& task, ::std::ostream* os);

[awong, 2014/08/26 00:33:19]

This should be a method in TestPendingTask.

[mithro-old, 2014/08/26 01:34:54]

gtest requires this method to be in the name space but not on the object.

[awong, 2014/08/27 20:51:21]

Ah hah...I just went and read the gtest documentation. I think you only need the
operator<<. Shall we delete the PrintTo?

Also, we don't normally root std namespace off of ::. Change to just std::
instead? Yeah, it's somewhat more ambiguous, but since the whole rest of the
codebase does this w/o much of a problem, we should stay consistent.

+
 }  // namespace base
 
-#endif  // BASE_TEST_TEST_TASK_RUNNER_H_
+#endif  // BASE_TEST_TEST_PENDING_TASK_H_